Page MenuHomeFreeBSD
Differential D40414

dtrace: move kinst tests to common
ClosedPublic
Actions

Authored by christos on Jun 3 2023, 8:33 PM.
Tags
None
Referenced Files
F146319400: D40414.id.diff
Sun, Mar 1, 5:18 PM
F146262817: D40414.id.diff
Sun, Mar 1, 5:22 AM
F146259304: D40414.id.diff
Sun, Mar 1, 4:37 AM
Unknown Object (File)
Sat, Feb 28, 10:59 AM
Unknown Object (File)
Sat, Feb 21, 12:16 AM
Unknown Object (File)
Fri, Feb 20, 11:29 PM
Unknown Object (File)
Thu, Feb 19, 2:20 PM
Unknown Object (File)
Jan 29 2026, 11:36 PM
View All Files
Subscribers
imp
vangyzen

Details

Reviewers
markj
gnn
Commits
rG911f0260390e: dtrace: move kinst tests to common

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 51897
Build 48788: arc lint + arc unit

Event Timeline

christos created this revision.Jun 3 2023, 8:33 PM
Herald added a reviewer: gnn. · View Herald TranscriptJun 3 2023, 8:33 PM
Herald added a subscriber: imp. · View Herald Transcript
christos requested review of this revision.Jun 3 2023, 8:33 PM
Harbormaster completed remote builds in B51891: Diff 122811.Jun 3 2023, 8:33 PM
markj added a comment.Jun 4 2023, 3:15 PM

Looks like the makefile update is missing?

christos updated this revision to Diff 122828.Jun 4 2023, 5:47 PM

Fix Makefiles.

Harbormaster completed remote builds in B51896: Diff 122828.Jun 4 2023, 5:47 PM
christos updated this revision to Diff 122829.Jun 4 2023, 5:49 PM

Forgot to add kinst to common/Makefile.

Harbormaster completed remote builds in B51897: Diff 122829.Jun 4 2023, 5:49 PM
christos added a comment.Jun 4 2023, 5:50 PM
In D40414#920176, @markj wrote:

Looks like the makefile update is missing?

That's true, my bad!

markj accepted this revision.Jul 4 2023, 3:46 PM

Approved.

This revision is now accepted and ready to land.Jul 4 2023, 3:46 PM
Closed by commit rG911f0260390e: dtrace: move kinst tests to common (authored by christos). · Explain WhyJul 4 2023, 3:47 PM
This revision was automatically updated to reflect the committed changes.
christos added a commit: rG911f0260390e: dtrace: move kinst tests to common.
vangyzen added a subscriber: vangyzen.EditedJul 7 2023, 11:22 AM

This needs a change in etc/mtree/BSD.tests.dist and perhaps ObsoleteFiles.inc.

Revision Contents
Changeset List

PathSize
cddl/
contrib/
opensolaris/
cmd/
dtrace/
test/
tst/
amd64/
kinst/
common/
kinst/
amd64/
kinst/
48 lines
usr.sbin/
dtrace/
tests/
amd64/
3 lines
kinst/
common/
1 line
common/
kinst/
amd64/
kinst/
19 lines

Diff 122829

View Options

cddl/contrib/opensolaris/cmd/dtrace/test/tst/amd64/kinst/tst.basic.ksh

Loading...
View Options

cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/kinst/tst.basic.ksh

Loading...
View Options

cddl/usr.sbin/dtrace/tests/amd64/Makefile

Loading...
View Options

cddl/usr.sbin/dtrace/tests/amd64/kinst/Makefile

Loading...
View Options

cddl/usr.sbin/dtrace/tests/common/Makefile

Loading...
View Options

cddl/usr.sbin/dtrace/tests/common/kinst/Makefile

Loading...