Differential D40335

dtrace: deduplicate some RISC-V functions
ClosedPublic
Actions

Authored by christos on May 30 2023, 2:59 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Feb 16, 1:42 AM

	Unknown Object (File)
	Sun, Feb 8, 11:09 AM

	Unknown Object (File)
	Sun, Feb 8, 12:19 AM

	Unknown Object (File)
	Sat, Jan 31, 1:32 PM

	Unknown Object (File)
	Mon, Jan 26, 3:10 PM

	Unknown Object (File)
	Mon, Jan 26, 1:10 AM

	Unknown Object (File)
	Sun, Jan 25, 10:38 PM

	Unknown Object (File)
	Sun, Jan 25, 9:29 PM

Subscribers

Details

Reviewers

markj
gnn
mhorne

Commits

rG7a8cf053d15e: dtrace: deduplicate some RISC-V functions

Summary

match_opcode() is defined in FBT, kinst, and dtrace_subr.c. The function
prologue-checking functions are defined in FBT and kinst.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 51778
Build 48669: arc lint + arc unit

Event Timeline

christos created this revision.May 30 2023, 2:59 PM

Herald added a reviewer: gnn. · View Herald TranscriptMay 30 2023, 2:59 PM

Herald added subscribers: riscv, imp. · View Herald Transcript

christos requested review of this revision.May 30 2023, 2:59 PM

Harbormaster completed remote builds in B51778: Diff 122614.May 30 2023, 2:59 PM

christos added a reviewer: mhorne.May 30 2023, 3:00 PM

Approved.

This revision is now accepted and ready to land.May 30 2023, 3:02 PM

Closed by commit rG7a8cf053d15e: dtrace: deduplicate some RISC-V functions (authored by christos). · Explain WhyMay 30 2023, 3:07 PM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rG7a8cf053d15e: dtrace: deduplicate some RISC-V functions.

In the future, please leave the revision open long enough for reviewers to have a chance to look at it. Even though the change is straightforward, and it was accepted by Mark, maybe I would have seen something that he didn't. For me, the change came and went completely before I got back from lunch. Thanks!

In D40335#918378, @mhorne wrote:

In the future, please leave the revision open long enough for reviewers to have a chance to look at it. Even though the change is straightforward, and it was accepted by Mark, maybe I would have seen something that he didn't. For me, the change came and went completely before I got back from lunch. Thanks!

You're right. Sorry about that.

Revision Contents
Changeset List

Path

Size

sys/

cddl/

contrib/

opensolaris/

uts/

common/

sys/

8 lines

dev/

dtrace/

riscv/

73 lines

22 lines

fbt/

riscv/

56 lines

Diff 122614

sys/cddl/contrib/opensolaris/uts/common/sys/dtrace.h

Loading...

sys/cddl/dev/dtrace/riscv/dtrace_isa.c

Loading...

sys/cddl/dev/dtrace/riscv/dtrace_subr.c

Loading...

sys/cddl/dev/fbt/riscv/fbt_isa.c

Loading...