Page MenuHomeFreeBSD

LinuxKPI: add page pool skeleton
ClosedPublic

Authored by bz on May 23 2023, 11:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 16 2024, 2:30 PM
Unknown Object (File)
Feb 9 2024, 9:50 AM
Unknown Object (File)
Feb 8 2024, 11:33 PM
Unknown Object (File)
Feb 2 2024, 10:41 PM
Unknown Object (File)
Dec 7 2023, 2:18 PM
Unknown Object (File)
Oct 28 2023, 1:52 PM
Unknown Object (File)
Oct 27 2023, 3:33 PM
Unknown Object (File)
Oct 21 2023, 3:02 PM
Subscribers

Details

Summary

Add the page pool skeleton based on a wireless driver. We have to
sort out some struct page problems first before we can start
implementing this but that should happen independent of all other
changes.

MFC after: 10 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 51663
Build 48554: arc lint + arc unit

Event Timeline

bz requested review of this revision.May 23 2023, 11:23 PM
sys/compat/linuxkpi/common/include/net/page_pool.h
73

looks like this should take another arg?

89

could this be const? (even if not matching linux)

bz marked an inline comment as done.

Make function argument const as suggested by @emaste

sys/compat/linuxkpi/common/include/net/page_pool.h
73

Based on what? Have they changed things already again? Based on roughly v6.4-rc1 driver I see:

page = page_pool_dev_alloc_frag(q->page_pool, offset, size);
89

Probably. Given the input I get from the driver wasn't const I hadn't put thought into it yet. Not sure what Linux does. I'll change it.

sys/compat/linuxkpi/common/include/net/page_pool.h
73

@emaste based on what was your comment suggesting another argument? Did you check an older version of Linux and they have changed it?

emaste added inline comments.
sys/compat/linuxkpi/common/include/net/page_pool.h
73

Hmm, good question - looking now, I'm not sure what I was thinking.

This revision is now accepted and ready to land.Aug 7 2023, 3:50 AM
This revision was automatically updated to reflect the committed changes.