Page MenuHomeFreeBSD
Differential D4900

kqueue EVFILT_PROC: avoid collision between NOTE_CHILD and NOTE_EXIT
ClosedPublic
Actions

Authored by vangyzen on Jan 12 2016, 7:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 28, 11:42 PM
Unknown Object (File)
Wed, Nov 26, 1:48 AM
Unknown Object (File)
Sun, Nov 23, 1:22 AM
Unknown Object (File)
Fri, Nov 21, 5:32 AM
Unknown Object (File)
Fri, Nov 21, 5:28 AM
Unknown Object (File)
Fri, Nov 21, 5:27 AM
Unknown Object (File)
Fri, Nov 21, 5:17 AM
Unknown Object (File)
Fri, Nov 21, 5:15 AM
View All Files
Subscribers
dab
imp
jhb

Details

Reviewers
jmg
Commits
rS295012: kqueue EVFILT_PROC: avoid collision between NOTE_CHILD and NOTE_EXIT
Summary

NOTE_CHILD and NOTE_EXIT return something in kevent.data: the parent
pid (ppid) for NOTE_CHILD and the exit status for NOTE_EXIT.
Do not let the two events be combined, since one would overwrite
the other's data.

PR: 180385
MFC after: 2 weeks
Submitted by: David A. Bright <david_a_bright@dell.com>
Sponsored by: Dell Inc.

Test Plan

A unit test is included.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2083
Build 2091: arc lint + arc unit

Event Timeline

vangyzen updated this revision to Diff 12217.Jan 12 2016, 7:42 PM
vangyzen retitled this revision from to kqueue EVFILT_PROC: avoid collision between NOTE_CHILD and NOTE_EXIT.
vangyzen updated this object.
vangyzen edited the test plan for this revision. (Show Details)
Herald added a reviewer: jmg. · View Herald TranscriptJan 12 2016, 7:42 PM
Herald added a subscriber: imp. · View Herald Transcript
vangyzen updated this object.Jan 12 2016, 7:44 PM
vangyzen edited edge metadata.
jhb added a subscriber: jhb.Jan 12 2016, 8:28 PM

On the surface I think this looks good. Keeping NOTE_CHILD and NOTE_EXIT separate is definitely the right approach to avoid losing data.

tests/sys/kqueue/proc.c
98

I would probably say that a pipe() is best for a test, even if it is more work than a bare sleep().

194

s/CHILD/EXIT/

vangyzen updated this revision to Diff 12225.Jan 13 2016, 1:38 AM

Use a pipe, instead of sleeping, for process synchronization.

Fix a copy-and-paste-o.

vangyzen added inline comments.Jan 13 2016, 1:40 AM
tests/sys/kqueue/proc.c
98

Agreed. In fact, the code that found this uses a pipe.

dab added a subscriber: dab.Jan 19 2016, 3:59 PM
Closed by commit rS295012: kqueue EVFILT_PROC: avoid collision between NOTE_CHILD and NOTE_EXIT (authored by vangyzen). · Explain WhyJan 28 2016, 8:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
kern/
61 lines
sys/
1 line
tests/
sys/
kqueue/
1 line
75 lines
151 lines

Diff 12217

View Options

sys/kern/kern_event.c

Loading...
View Options

sys/sys/event.h

Loading...
View Options

tests/sys/kqueue/common.h

Loading...
View Options

tests/sys/kqueue/main.c

Loading...
View Options

tests/sys/kqueue/proc.c

Loading...