Details

Reviewers

Commits

rS293724: Enable warnings in EFI boot code

Summary

Set WARNS if not set for EFI boot code and fix the issues highlighted by setting it.

Most components are set to WARNS level 6 with few being left at lower levels due to the amount of changes needed to fix at higher levels.

Test Plan

make buildenv
cd sys/boot/efi
make clean
make

Once built boot using the created boot.efifat image under qemu.

Also:

make tinderbox JFLAG=-j24 MAKE_JUST_WORLDS=1

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2041
Build 2049: arc lint + arc unit

Event Timeline

smh updated this revision to Diff 12069.Jan 9 2016, 3:49 AM

smh retitled this revision from to Enable warnings in EFI boot code.

smh updated this object.

smh edited the test plan for this revision. (Show Details)

smh added a reviewer: emaste.

Herald added subscribers: rpokala, imp. · View Herald TranscriptJan 9 2016, 3:49 AM

Restore removed blank line and correct spacing highlighted by phabricator view.

Additional spacing fix

emaste added inline comments.Jan 11 2016, 1:04 PM

sys/boot/efi/Makefile
5–6 ↗	(On Diff #12111)	This makefile doesn't build anything, so this will have no effect?
sys/boot/efi/boot1/Makefile
7–8	Seems WARNS conventionally goes after PROG= etc. in other Makefiles.
sys/boot/efi/include/efi_nii.h
29–30	Looks good, but I'd suggest removing the line continuation (even though it's then longer than 80 cols) to reduce diffs with other versions of this file. Here's NetBSD's, which seems to come via gnu-efi: http://cvsweb.netbsd.org/bsdweb.cgi/src/sys/external/bsd/gnu-efi/dist/inc/efi_nii.h?annotate=1.1.1.1&only_with_tag=MAIN #define EFI_NETWORK_INTERFACE_IDENTIFIER_PROTOCOL \ { 0xE18541CD, 0xF755, 0x4f73, {0x92, 0x8D, 0x64, 0x3C, 0x8A, 0x79, 0xB2, 0x29} } I'd say we should follow that formatting.

Address feedback from emaste:

Remove WARNS from sys/boot/efi/Makefile as it has no effect
Move WARNS below PROG= etc
Remove split of GUID / PROTOCOL defines even though they break style(9) 80 col limit, to reduce diff and match NetBSD.

smh marked 3 inline comments as done.Jan 11 2016, 1:35 PM

emaste mentioned this in D4713: loader bcache redesign experiment.Jan 11 2016, 1:46 PM

Spacing changes for GUID / PROTOCOL structs requested emaste

Fix ARM warnings highlighted by tinderbox.

Herald added a subscriber: andrew. · View Herald TranscriptJan 11 2016, 8:46 PM

smh edited the test plan for this revision. (Show Details)Jan 12 2016, 2:08 AM

Closed by commit rS293724: Enable warnings in EFI boot code (authored by smh). · Explain WhyJan 12 2016, 2:18 AM

This revision was automatically updated to reflect the committed changes.

Enable warnings in EFI boot codeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 12126

sys/boot/arm64/libarm64/cache.c

sys/boot/common/load_elf.c

sys/boot/common/load_elf_obj.c

sys/boot/common/misc.c

sys/boot/common/module.c

sys/boot/common/part.c

sys/boot/common/self_reloc.c

sys/boot/common/ufsread.c

sys/boot/efi/boot1/Makefile

sys/boot/efi/boot1/boot1.c

sys/boot/efi/fdt/Makefile

sys/boot/efi/fdt/efi_fdt.c

sys/boot/efi/include/arm64/efibind.h

sys/boot/efi/include/efi_nii.h

sys/boot/efi/include/efiapi.h

sys/boot/efi/include/eficon.h

sys/boot/efi/include/eficonsctl.h

sys/boot/efi/include/efidevp.h

sys/boot/efi/include/efierr.h

sys/boot/efi/include/efifpswa.h

sys/boot/efi/include/efigop.h

sys/boot/efi/include/efilib.h

sys/boot/efi/include/efinet.h

sys/boot/efi/include/efipciio.h

sys/boot/efi/include/efiprot.h

sys/boot/efi/include/efipxebc.h

sys/boot/efi/include/efiser.h

sys/boot/efi/include/efiuga.h

sys/boot/efi/libefi/Makefile

sys/boot/efi/libefi/efi_console.c

sys/boot/efi/libefi/efipart.c

sys/boot/efi/libefi/libefi.c

sys/boot/efi/loader/Makefile

sys/boot/efi/loader/arch/amd64/elf64_freebsd.c

sys/boot/efi/loader/arch/amd64/framebuffer.c

sys/boot/efi/loader/arch/arm/exec.c

sys/boot/efi/loader/arch/arm64/exec.c

sys/boot/efi/loader/autoload.c

sys/boot/efi/loader/bootinfo.c

sys/boot/efi/loader/copy.c

sys/boot/efi/loader/devicename.c

sys/boot/efi/loader/loader_efi.h

sys/boot/efi/loader/main.c

sys/boot/i386/libi386/smbios.c

Enable warnings in EFI boot code
ClosedPublic
Actions

Revision Contents
Changeset List