Details

Reviewers

avg
jhb
imp

Commits

rGa9ee57e46ff0: jedec_dimm(4): Add manufacturing year and week.
rG861fdb46300b: jedec_dimm(4): Add manufacturing year and week.
rGde57e0ef5a15: jedec_dimm(4): Add manufacturing year and week.

Summary

DDR3 and DDR4 encode the week and year that the DIMM was manufactured,
as a pair of two-digit binary-coded decimal values. Read the values, and
report them as (uint8_t)s.

Tested by: Nick Mills (Panasas)
MFC after: 1 week
Sponsored by: Panasas

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 51190
Build 48081: arc lint + arc unit

Event Timeline

rpokala created this revision.Apr 25 2023, 6:14 AM

Herald added a subscriber: imp. · View Herald TranscriptApr 25 2023, 6:14 AM

rpokala requested review of this revision.Apr 25 2023, 6:14 AM

Harbormaster completed remote builds in B51170: Diff 120980.Apr 25 2023, 6:14 AM

Update the date for the manpage.

Harbormaster completed remote builds in B51171: Diff 120981.Apr 25 2023, 6:22 AM

rpokala added a reviewer: avg.Apr 25 2023, 6:24 AM

Describe new fields in jedec_dimm.4

Harbormaster completed remote builds in B51190: Diff 121024.Apr 25 2023, 5:36 PM

jhb added a subscriber: jhb.Apr 25 2023, 6:29 PM

jhb added inline comments.

sys/dev/jedec_dimm/jedec_dimm.c
883	Maybe use __assert_unreachable() here since the caller has already checked this?

rpokala added inline comments.Apr 25 2023, 6:32 PM

sys/dev/jedec_dimm/jedec_dimm.c
883	There are a few other bits of cleanup/refactoring that I'm going to do a bit later; I'll add this to the list.

jhb accepted this revision.Apr 26 2023, 5:11 PM

This revision is now accepted and ready to land.Apr 26 2023, 5:11 PM

modulo a minor quibble over the copyright form, this looks good to me too (agree with john's comments, but also agree with your answer)

sys/dev/jedec_dimm/jedec_dimm.h
6	typically we'd use a '-' here rather than a ',' since ranges of copyright years are all that are really needed.... Unless your IP department insists on the comma, please consider changing.