Page MenuHomeFreeBSD

jedec_dimm(4): Add manufacturing year and week.
ClosedPublic

Authored by rpokala on Apr 25 2023, 6:14 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jul 4, 5:25 PM
Unknown Object (File)
Mon, Jun 24, 4:29 PM
Unknown Object (File)
Thu, Jun 20, 11:05 PM
Unknown Object (File)
May 6 2024, 9:49 AM
Unknown Object (File)
May 6 2024, 12:23 AM
Unknown Object (File)
Apr 29 2024, 8:17 PM
Unknown Object (File)
Apr 28 2024, 6:08 AM
Unknown Object (File)
Apr 28 2024, 5:27 AM
Subscribers

Details

Summary

DDR3 and DDR4 encode the week and year that the DIMM was manufactured,
as a pair of two-digit binary-coded decimal values. Read the values, and
report them as (uint8_t)s.

Tested by: Nick Mills (Panasas)
MFC after: 1 week
Sponsored by: Panasas

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 51171
Build 48062: arc lint + arc unit

Event Timeline

Update the date for the manpage.

Describe new fields in jedec_dimm.4

jhb added inline comments.
sys/dev/jedec_dimm/jedec_dimm.c
883

Maybe use __assert_unreachable() here since the caller has already checked this?

sys/dev/jedec_dimm/jedec_dimm.c
883

There are a few other bits of cleanup/refactoring that I'm going to do a bit later; I'll add this to the list.

This revision is now accepted and ready to land.Apr 26 2023, 5:11 PM

modulo a minor quibble over the copyright form, this looks good to me too (agree with john's comments, but also agree with your answer)

sys/dev/jedec_dimm/jedec_dimm.h
6

typically we'd use a '-' here rather than a ',' since ranges of copyright years are all that are really needed.... Unless your IP department insists on the comma, please consider changing.

Reformat copyright, per imp@'s request.

This revision now requires review to proceed.Apr 26 2023, 5:24 PM
sys/dev/jedec_dimm/jedec_dimm.c
883

Cleanup is out for review in https://reviews.freebsd.org/D39842

like the changes, and nothing further catches my eye.

This revision is now accepted and ready to land.Apr 27 2023, 5:46 PM