Differential D39747

llvm: fix some llvm-* tool links when WITH_LLVM_BINUTILS set
ClosedPublic
Actions

Authored by emaste on Apr 21 2023, 1:18 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Nov 13, 4:24 AM

	Unknown Object (File)
	Tue, Oct 22, 9:56 AM

	Unknown Object (File)
	Tue, Oct 22, 7:11 AM

	Unknown Object (File)
	Oct 19 2024, 12:55 AM

	Unknown Object (File)
	Sep 30 2024, 1:11 PM

	Unknown Object (File)
	Sep 23 2024, 2:30 PM

	Unknown Object (File)
	Sep 23 2024, 3:26 AM

	Unknown Object (File)
	Sep 23 2024, 1:35 AM

View All 57 Files

Subscribers

Details

Reviewers

jbeich
dim
arichardson

Commits

rG3b63f0b70671: llvm: fix some llvm-* tool links when WITH_LLVM_BINUTILS is set
rG41df1d60e323: llvm: fix some llvm-* tool links when WITH_LLVM_BINUTILS is set

Summary

A few Makefiles overrode LINKS and MLINKS when WITH_LLVM_BINUTILS was
set, which caused e.g. the llvm-ranlib link to disappear.  Use += when
adding WITH_LLVM_BINUTILS LINKS and MLINKS.

Thanks jbeich for spotting the issue.

PR:             270955, 270956, 270959
Fixes: 021385aba562 ("Add WITH_LLVM_BINUTILS to install LLVM binuti...")
Sponsored by:   The FreeBSD Foundation

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

llvm-symbolizer had the same issue; nm and size did not have other LINKS, but do the same there for consistency

emaste added a reviewer: arichardson.Apr 21 2023, 1:36 PM

arichardson accepted this revision.Apr 21 2023, 2:11 PM

This revision is now accepted and ready to land.Apr 21 2023, 2:11 PM

Closed by commit rG41df1d60e323: llvm: fix some llvm-* tool links when WITH_LLVM_BINUTILS is set (authored by emaste). · Explain WhyApr 21 2023, 4:51 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG41df1d60e323: llvm: fix some llvm-* tool links when WITH_LLVM_BINUTILS is set.

Herald added a subscriber: imp. · View Herald TranscriptApr 21 2023, 4:51 PM

emaste added a commit: rG3b63f0b70671: llvm: fix some llvm-* tool links when WITH_LLVM_BINUTILS is set.Apr 27 2023, 6:20 PM

Revision Contents
Changeset List

Path

Size

usr.bin/

clang/

llvm-ar/

4 lines

llvm-nm/

4 lines

llvm-size/

4 lines

llvm-strings/

4 lines

llvm-symbolizer/

4 lines

Diff 120808

usr.bin/clang/llvm-ar/Makefile

Loading...

usr.bin/clang/llvm-nm/Makefile

Loading...

usr.bin/clang/llvm-size/Makefile

Loading...

usr.bin/clang/llvm-strings/Makefile

Loading...

usr.bin/clang/llvm-symbolizer/Makefile

Loading...