xargs: improve foundeof check for -E
ClosedPublic
Actions

Authored by yuripv on Apr 15 2023, 5:27 PM.

Tags

None

Referenced Files

	F87218956: D39583.id120362.diff
	Sun, Jun 30, 10:18 AM

	F87217918: D39583.id120509.diff
	Sun, Jun 30, 9:59 AM

	Unknown Object (File)
	Fri, Jun 28, 12:18 AM

	Unknown Object (File)
	May 31 2024, 9:17 AM

	Unknown Object (File)
	Jan 2 2024, 4:16 PM

	Unknown Object (File)
	Dec 24 2023, 4:13 PM

	Unknown Object (File)
	Dec 22 2023, 11:36 PM

	Unknown Object (File)
	Nov 2 2023, 5:06 AM

View All 12 Files

Subscribers

imp

Details

Reviewers

bapt
kevans

Commits

rG21ef48af5c0f: xargs: improve foundeof check for -E

Summary

PR: 270867

4aeb63826e0f got it almost correct (we can't use strcmp() here as
current argument isn't guaranteed to be NUL-terminated), but we also
need to check that current argument length is equal to that of eofstr.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

yuripv created this revision.Apr 15 2023, 5:27 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 15 2023, 5:27 PM

yuripv requested review of this revision.Apr 15 2023, 5:27 PM

yuripv added reviewers: bapt, kevans.Apr 17 2023, 2:43 PM

bapt accepted this revision.Apr 17 2023, 2:49 PM

This revision is now accepted and ready to land.Apr 17 2023, 2:49 PM

Closed by commit rG21ef48af5c0f: xargs: improve foundeof check for -E (authored by yuripv). · Explain WhyApr 17 2023, 8:22 PM

This revision was automatically updated to reflect the committed changes.

yuripv added a commit: rG21ef48af5c0f: xargs: improve foundeof check for -E.

des mentioned this in rGbc47005a648b: xargs: terminate if line replacement cannot be constructed.Jun 14 2023, 1:26 PM

Revision Contents
Changeset List

Path

Size

usr.bin/

xargs/

xargs.c

7 lines

Diff 120509

View Options

xargs: improve foundeof check for -EClosedPublicActions