Differential D4827

sed: Use S_ISREG.
ClosedPublic
Actions

Authored by delphij on Jan 8 2016, 6:33 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Jan 3, 7:54 AM

	Unknown Object (File)
	Wed, Jan 1, 5:41 PM

	Unknown Object (File)
	Nov 29 2024, 9:19 AM

	Unknown Object (File)
	Nov 23 2024, 6:39 AM

	Unknown Object (File)
	Nov 22 2024, 1:37 PM

	Unknown Object (File)
	Nov 21 2024, 5:47 PM

	Unknown Object (File)
	Oct 17 2024, 5:55 AM

	Unknown Object (File)
	Oct 16 2024, 5:35 PM

View All 85 Files

Subscribers

Details

Reviewers

Commits

rG1781324db2bc: TCP BBR: remove code which is never executed
rS313277: Restore r312404:
rS312404: Use S_ISREG instead of manual & (also it's better to compare the

Summary

Use S_ISREG instead of manual & (also it's better to compare the
result from & and the pattern instead of just assuming it's one bit
value).

Pointed out by Tianjie Mao <tjmao tjmao com>.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1996
Build 2004: arc lint + arc unit

Event Timeline

delphij updated this revision to Diff 12037.Jan 8 2016, 6:33 AM

delphij retitled this revision from to Use S_ISREG..

delphij updated this object.

delphij edited the test plan for this revision. (Show Details)

delphij added a reviewer: des.

Herald added a subscriber: imp. · View Herald TranscriptJan 8 2016, 6:33 AM

delphij retitled this revision from Use S_ISREG. to sed: Use S_ISREG..Jan 8 2016, 6:34 AM

Closed by commit rS312404: Use S_ISREG instead of manual & (also it's better to compare the (authored by delphij). · Explain WhyJan 19 2017, 8:01 AM

This revision was automatically updated to reflect the committed changes.

This change breaks sed -i on symlinks which breaks lots of ports.

tuexen added a commit: rG1781324db2bc: TCP BBR: remove code which is never executed.Wed, Jan 1, 5:42 PM

Revision Contents
Changeset List

Path

Size

usr.bin/

sed/

2 lines

Diff 12037

usr.bin/sed/main.c

Loading...