Page MenuHomeFreeBSD
Differential D39520

bootpd: Use C89 function definitions.
ClosedPublic
Actions

Authored by jhb on Apr 12 2023, 3:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 18 2025, 3:49 AM
Unknown Object (File)
Nov 29 2024, 4:10 AM
Unknown Object (File)
Nov 29 2024, 2:44 AM
Unknown Object (File)
Nov 25 2024, 8:57 AM
Unknown Object (File)
Nov 23 2024, 4:10 PM
Unknown Object (File)
Nov 19 2024, 12:52 AM
Unknown Object (File)
Nov 18 2024, 11:54 PM
Unknown Object (File)
Nov 18 2024, 9:11 PM
View All 72 Files
Subscribers
imp

Details

Reviewers
emaste
Commits
rG8b356c888167: bootpd: Use C89 function definitions.
Summary

Trim a few duplicate (but incomplete) function prototypes as well.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 50851
Build 47742: arc lint + arc unit

Event Timeline

jhb created this revision.Apr 12 2023, 3:32 PM
Herald added a subscriber: imp. · View Herald TranscriptApr 12 2023, 3:32 PM
jhb requested review of this revision.Apr 12 2023, 3:32 PM
Harbormaster completed remote builds in B50851: Diff 120199.Apr 12 2023, 3:32 PM
jhb added a parent revision: D39519: smbfs: Use C89 function definition for cf_getopt..Apr 12 2023, 3:32 PM
jhb added a child revision: D39521: rpc.rstatd/rwalld: Use more accurate function pointer types..
emaste accepted this revision.Apr 12 2023, 3:58 PM
emaste added inline comments.
libexec/bootpd/dovend.c
39

perhaps we can change these to uint8_t in a subsequent commit?

libexec/bootpd/report.c
38

this seems kind of odd (unrelated to your work)

This revision is now accepted and ready to land.Apr 12 2023, 3:58 PM
jhb added inline comments.Apr 12 2023, 6:57 PM
libexec/bootpd/dovend.c
39

This entire codebase is in a different style from CMU. I tried to just focus on fixing the function definitions and leaving the rest alone.

libexec/bootpd/report.c
38

There's a lot of oddness in this code. :/

Closed by commit rG8b356c888167: bootpd: Use C89 function definitions. (authored by jhb). · Explain WhyApr 18 2023, 6:32 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG8b356c888167: bootpd: Use C89 function definitions..

Revision Contents
Changeset List

PathSize
libexec/
bootpd/
28 lines
bootpgw/
4 lines
2 lines
20 lines
18 lines
4 lines
7 lines
50 lines
21 lines
15 lines
95 lines
5 lines
10 lines
tools/
bootpef/
9 lines
bootptest/
13 lines
21 lines

Diff 120199

View Options

libexec/bootpd/bootpd.c

Show First 20 Lines • Show All 405 Lines • ▼ Show 20 Lines
#define IF_ADDR_WLOCK(if) mtx_lock(&(if)->if_addr_lock) #define IF_ADDR_WLOCK(if) mtx_lock(&(if)->if_addr_lock)
#define IF_ADDR_WUNLOCK(if) mtx_unlock(&(if)->if_addr_lock) #define IF_ADDR_WUNLOCK(if) mtx_unlock(&(if)->if_addr_lock)
#define IF_ADDR_LOCK_ASSERT(if) MPASS(in_epoch(net_epoch_preempt) || mtx_owned(&(if)->if_addr_lock)) #define IF_ADDR_LOCK_ASSERT(if) MPASS(in_epoch(net_epoch_preempt) || mtx_owned(&(if)->if_addr_lock))
#define IF_ADDR_WLOCK_ASSERT(if) mtx_assert(&(if)->if_addr_lock, MA_OWNED) #define IF_ADDR_WLOCK_ASSERT(if) mtx_assert(&(if)->if_addr_lock, MA_OWNED)
#define NET_EPOCH_ENTER() struct epoch_tracker nep_et; epoch_enter_preempt(net_epoch_preempt, &nep_et) #define NET_EPOCH_ENTER() struct epoch_tracker nep_et; epoch_enter_preempt(net_epoch_preempt, &nep_et)
#define NET_EPOCH_ENTER_ET(et) epoch_enter_preempt(net_epoch_preempt, &(et)) #define NET_EPOCH_ENTER_ET(et) epoch_enter_preempt(net_epoch_preempt, &(et))
#define NET_EPOCH_EXIT() epoch_exit_preempt(net_epoch_preempt, &nep_et) #define NET_EPOCH_EXIT() epoch_exit_preempt(net_epoch_preempt, &nep_et)
#define NET_EPOCH_EXIT_ET(et) epoch_exit_preempt(net_epoch_preempt, &(et)) #define NET_EPOCH_EXIT_ET(et) epoch_exit_preempt(net_epoch_preempt, &(et))
#define NET_EPOCH_WAIT() epoch_wait_preempt(net_epoch_preempt)
/* /*
* Function variations on locking macros intended to be used by loadable * Function variations on locking macros intended to be used by loadable
* kernel modules in order to divorce them from the internals of address list * kernel modules in order to divorce them from the internals of address list
* locking. * locking.
*/ */
void if_addr_rlock(struct ifnet *ifp); /* if_addrhead */ void if_addr_rlock(struct ifnet *ifp); /* if_addrhead */
void if_addr_runlock(struct ifnet *ifp); /* if_addrhead */ void if_addr_runlock(struct ifnet *ifp); /* if_addrhead */
▲ Show 20 Lines • Show All 352 Lines • Show Last 20 Lines
View Options

libexec/bootpd/bootpgw/bootpgw.c

Show First 20 Lines • Show All 405 Lines • ▼ Show 20 Lines
#define IF_ADDR_WLOCK(if) mtx_lock(&(if)->if_addr_lock) #define IF_ADDR_WLOCK(if) mtx_lock(&(if)->if_addr_lock)
#define IF_ADDR_WUNLOCK(if) mtx_unlock(&(if)->if_addr_lock) #define IF_ADDR_WUNLOCK(if) mtx_unlock(&(if)->if_addr_lock)
#define IF_ADDR_LOCK_ASSERT(if) MPASS(in_epoch(net_epoch_preempt) || mtx_owned(&(if)->if_addr_lock)) #define IF_ADDR_LOCK_ASSERT(if) MPASS(in_epoch(net_epoch_preempt) || mtx_owned(&(if)->if_addr_lock))
#define IF_ADDR_WLOCK_ASSERT(if) mtx_assert(&(if)->if_addr_lock, MA_OWNED) #define IF_ADDR_WLOCK_ASSERT(if) mtx_assert(&(if)->if_addr_lock, MA_OWNED)
#define NET_EPOCH_ENTER() struct epoch_tracker nep_et; epoch_enter_preempt(net_epoch_preempt, &nep_et) #define NET_EPOCH_ENTER() struct epoch_tracker nep_et; epoch_enter_preempt(net_epoch_preempt, &nep_et)
#define NET_EPOCH_ENTER_ET(et) epoch_enter_preempt(net_epoch_preempt, &(et)) #define NET_EPOCH_ENTER_ET(et) epoch_enter_preempt(net_epoch_preempt, &(et))
#define NET_EPOCH_EXIT() epoch_exit_preempt(net_epoch_preempt, &nep_et) #define NET_EPOCH_EXIT() epoch_exit_preempt(net_epoch_preempt, &nep_et)
#define NET_EPOCH_EXIT_ET(et) epoch_exit_preempt(net_epoch_preempt, &(et)) #define NET_EPOCH_EXIT_ET(et) epoch_exit_preempt(net_epoch_preempt, &(et))
#define NET_EPOCH_WAIT() epoch_wait_preempt(net_epoch_preempt)
/* /*
* Function variations on locking macros intended to be used by loadable * Function variations on locking macros intended to be used by loadable
* kernel modules in order to divorce them from the internals of address list * kernel modules in order to divorce them from the internals of address list
* locking. * locking.
*/ */
void if_addr_rlock(struct ifnet *ifp); /* if_addrhead */ void if_addr_rlock(struct ifnet *ifp); /* if_addrhead */
void if_addr_runlock(struct ifnet *ifp); /* if_addrhead */ void if_addr_runlock(struct ifnet *ifp); /* if_addrhead */
▲ Show 20 Lines • Show All 352 Lines • Show Last 20 Lines
View Options

libexec/bootpd/dovend.h

Show First 20 Lines • Show All 405 Lines • ▼ Show 20 Lines
#define IF_ADDR_WLOCK(if) mtx_lock(&(if)->if_addr_lock) #define IF_ADDR_WLOCK(if) mtx_lock(&(if)->if_addr_lock)
#define IF_ADDR_WUNLOCK(if) mtx_unlock(&(if)->if_addr_lock) #define IF_ADDR_WUNLOCK(if) mtx_unlock(&(if)->if_addr_lock)
#define IF_ADDR_LOCK_ASSERT(if) MPASS(in_epoch(net_epoch_preempt) || mtx_owned(&(if)->if_addr_lock)) #define IF_ADDR_LOCK_ASSERT(if) MPASS(in_epoch(net_epoch_preempt) || mtx_owned(&(if)->if_addr_lock))
#define IF_ADDR_WLOCK_ASSERT(if) mtx_assert(&(if)->if_addr_lock, MA_OWNED) #define IF_ADDR_WLOCK_ASSERT(if) mtx_assert(&(if)->if_addr_lock, MA_OWNED)
#define NET_EPOCH_ENTER() struct epoch_tracker nep_et; epoch_enter_preempt(net_epoch_preempt, &nep_et) #define NET_EPOCH_ENTER() struct epoch_tracker nep_et; epoch_enter_preempt(net_epoch_preempt, &nep_et)
#define NET_EPOCH_ENTER_ET(et) epoch_enter_preempt(net_epoch_preempt, &(et)) #define NET_EPOCH_ENTER_ET(et) epoch_enter_preempt(net_epoch_preempt, &(et))
#define NET_EPOCH_EXIT() epoch_exit_preempt(net_epoch_preempt, &nep_et) #define NET_EPOCH_EXIT() epoch_exit_preempt(net_epoch_preempt, &nep_et)
#define NET_EPOCH_EXIT_ET(et) epoch_exit_preempt(net_epoch_preempt, &(et)) #define NET_EPOCH_EXIT_ET(et) epoch_exit_preempt(net_epoch_preempt, &(et))
#define NET_EPOCH_WAIT() epoch_wait_preempt(net_epoch_preempt)
/* /*
* Function variations on locking macros intended to be used by loadable * Function variations on locking macros intended to be used by loadable
* kernel modules in order to divorce them from the internals of address list * kernel modules in order to divorce them from the internals of address list
* locking. * locking.
*/ */
void if_addr_rlock(struct ifnet *ifp); /* if_addrhead */ void if_addr_rlock(struct ifnet *ifp); /* if_addrhead */
void if_addr_runlock(struct ifnet *ifp); /* if_addrhead */ void if_addr_runlock(struct ifnet *ifp); /* if_addrhead */
▲ Show 20 Lines • Show All 352 Lines • Show Last 20 Lines
View Options

libexec/bootpd/dovend.c

Show First 20 Lines • Show All 405 Lines • ▼ Show 20 Lines
#define IF_ADDR_WLOCK(if) mtx_lock(&(if)->if_addr_lock) #define IF_ADDR_WLOCK(if) mtx_lock(&(if)->if_addr_lock)
#define IF_ADDR_WUNLOCK(if) mtx_unlock(&(if)->if_addr_lock) #define IF_ADDR_WUNLOCK(if) mtx_unlock(&(if)->if_addr_lock)
#define IF_ADDR_LOCK_ASSERT(if) MPASS(in_epoch(net_epoch_preempt) || mtx_owned(&(if)->if_addr_lock)) #define IF_ADDR_LOCK_ASSERT(if) MPASS(in_epoch(net_epoch_preempt) || mtx_owned(&(if)->if_addr_lock))
#define IF_ADDR_WLOCK_ASSERT(if) mtx_assert(&(if)->if_addr_lock, MA_OWNED) #define IF_ADDR_WLOCK_ASSERT(if) mtx_assert(&(if)->if_addr_lock, MA_OWNED)
#define NET_EPOCH_ENTER() struct epoch_tracker nep_et; epoch_enter_preempt(net_epoch_preempt, &nep_et) #define NET_EPOCH_ENTER() struct epoch_tracker nep_et; epoch_enter_preempt(net_epoch_preempt, &nep_et)
#define NET_EPOCH_ENTER_ET(et) epoch_enter_preempt(net_epoch_preempt, &(et)) #define NET_EPOCH_ENTER_ET(et) epoch_enter_preempt(net_epoch_preempt, &(et))
#define NET_EPOCH_EXIT() epoch_exit_preempt(net_epoch_preempt, &nep_et) #define NET_EPOCH_EXIT() epoch_exit_preempt(net_epoch_preempt, &nep_et)
#define NET_EPOCH_EXIT_ET(et) epoch_exit_preempt(net_epoch_preempt, &(et)) #define NET_EPOCH_EXIT_ET(et) epoch_exit_preempt(net_epoch_preempt, &(et))
#define NET_EPOCH_WAIT() epoch_wait_preempt(net_epoch_preempt)
/* /*
* Function variations on locking macros intended to be used by loadable * Function variations on locking macros intended to be used by loadable
* kernel modules in order to divorce them from the internals of address list * kernel modules in order to divorce them from the internals of address list
* locking. * locking.
*/ */
void if_addr_rlock(struct ifnet *ifp); /* if_addrhead */ void if_addr_rlock(struct ifnet *ifp); /* if_addrhead */
void if_addr_runlock(struct ifnet *ifp); /* if_addrhead */ void if_addr_runlock(struct ifnet *ifp); /* if_addrhead */
▲ Show 20 Lines • Show All 352 Lines • Show Last 20 Lines
View Options

libexec/bootpd/dumptab.c

Loading...
View Options

libexec/bootpd/getether.c

Loading...
View Options

libexec/bootpd/getif.c

Loading...
View Options

libexec/bootpd/hash.c

Loading...
View Options

libexec/bootpd/hwaddr.c

Loading...
View Options

libexec/bootpd/lookup.c

Loading...
View Options

libexec/bootpd/readfile.c

Loading...
View Options

libexec/bootpd/report.c

Loading...
View Options

libexec/bootpd/rtmsg.c

Loading...
View Options

libexec/bootpd/tools/bootpef/bootpef.c

Loading...
View Options

libexec/bootpd/tools/bootptest/bootptest.c

Loading...
View Options

libexec/bootpd/tools/bootptest/print-bootp.c

Loading...