Page MenuHomeFreeBSD

bootpd: Use C89 function definitions.
ClosedPublic

Authored by jhb on Apr 12 2023, 3:32 PM.
Tags
None
Referenced Files
F131790343: D39520.id120586.diff
Sat, Oct 11, 4:43 AM
F131766674: D39520.diff
Sat, Oct 11, 12:14 AM
Unknown Object (File)
Sep 9 2025, 7:53 PM
Unknown Object (File)
Sep 9 2025, 5:16 AM
Unknown Object (File)
Sep 4 2025, 1:12 AM
Unknown Object (File)
Sep 3 2025, 8:25 PM
Unknown Object (File)
Aug 14 2025, 11:05 PM
Unknown Object (File)
Aug 14 2025, 10:13 PM
Subscribers

Details

Summary

Trim a few duplicate (but incomplete) function prototypes as well.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 50851
Build 47742: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Apr 12 2023, 3:32 PM
emaste added inline comments.
libexec/bootpd/dovend.c
39

perhaps we can change these to uint8_t in a subsequent commit?

libexec/bootpd/report.c
38

this seems kind of odd (unrelated to your work)

This revision is now accepted and ready to land.Apr 12 2023, 3:58 PM
libexec/bootpd/dovend.c
39

This entire codebase is in a different style from CMU. I tried to just focus on fixing the function definitions and leaving the rest alone.

libexec/bootpd/report.c
38

There's a lot of oddness in this code. :/

This revision was automatically updated to reflect the committed changes.