Page MenuHomeFreeBSD

bootpd: Use C89 function definitions.
ClosedPublic

Authored by jhb on Apr 12 2023, 3:32 PM.
Tags
None
Referenced Files
F103463543: D39520.diff
Mon, Nov 25, 8:57 AM
Unknown Object (File)
Sat, Nov 23, 4:10 PM
Unknown Object (File)
Tue, Nov 19, 12:52 AM
Unknown Object (File)
Mon, Nov 18, 11:54 PM
Unknown Object (File)
Mon, Nov 18, 9:11 PM
Unknown Object (File)
Thu, Nov 7, 3:59 PM
Unknown Object (File)
Oct 16 2024, 12:12 PM
Unknown Object (File)
Oct 15 2024, 8:57 PM
Subscribers

Details

Summary

Trim a few duplicate (but incomplete) function prototypes as well.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 50851
Build 47742: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Apr 12 2023, 3:32 PM
emaste added inline comments.
libexec/bootpd/dovend.c
39

perhaps we can change these to uint8_t in a subsequent commit?

libexec/bootpd/report.c
38

this seems kind of odd (unrelated to your work)

This revision is now accepted and ready to land.Apr 12 2023, 3:58 PM
libexec/bootpd/dovend.c
39

This entire codebase is in a different style from CMU. I tried to just focus on fixing the function definitions and leaving the rest alone.

libexec/bootpd/report.c
38

There's a lot of oddness in this code. :/

This revision was automatically updated to reflect the committed changes.