Page MenuHomeFreeBSD

bootpd: Use C89 function definitions.
ClosedPublic

Authored by jhb on Apr 12 2023, 3:32 PM.
Tags
None
Referenced Files
F84340519: D39520.diff
Wed, May 22, 3:06 PM
Unknown Object (File)
Fri, May 17, 4:18 PM
Unknown Object (File)
Sun, May 12, 7:45 PM
Unknown Object (File)
Fri, May 3, 5:39 AM
Unknown Object (File)
Mon, Apr 29, 3:05 AM
Unknown Object (File)
Apr 16 2024, 5:42 PM
Unknown Object (File)
Apr 12 2024, 8:06 AM
Unknown Object (File)
Mar 22 2024, 2:46 PM
Subscribers

Details

Summary

Trim a few duplicate (but incomplete) function prototypes as well.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Apr 12 2023, 3:32 PM
emaste added inline comments.
libexec/bootpd/dovend.c
39

perhaps we can change these to uint8_t in a subsequent commit?

libexec/bootpd/report.c
38

this seems kind of odd (unrelated to your work)

This revision is now accepted and ready to land.Apr 12 2023, 3:58 PM
libexec/bootpd/dovend.c
39

This entire codebase is in a different style from CMU. I tried to just focus on fixing the function definitions and leaving the rest alone.

libexec/bootpd/report.c
38

There's a lot of oddness in this code. :/

This revision was automatically updated to reflect the committed changes.