Paths

Table of Contentst

Differential D39365

tests: split netlink.py into multiple files to imporve maintainability.
ClosedPublic
Actions

Authored by melifaro on Mar 31 2023, 12:53 PM.

Tags

None

Referenced Files

	F87333309: D39365.id119711.diff
	Mon, Jul 1, 8:31 PM

	Unknown Object (File)
	Sat, Jun 29, 5:34 PM

	Unknown Object (File)
	Fri, Jun 28, 3:25 PM

	Unknown Object (File)
	Apr 13 2024, 2:48 PM

	Unknown Object (File)
	Apr 11 2024, 6:48 PM

	Unknown Object (File)
	Apr 11 2024, 6:48 PM

	Unknown Object (File)
	Apr 11 2024, 6:48 PM

	Unknown Object (File)
	Mar 4 2024, 2:37 AM

View All 20 Files

Subscribers

Details

Reviewers

None

Group Reviewers

network
tests

Commits

rGfee65b7e21ee: tests: split netlink.py into multiple files to impove maintainability.

Summary

No functional changes, just split netlink.py into smaller chunks.

This change simplifies further changes, mostly in the generic netlink scope.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Errors

Severity	Location	Code	Message
Error	tests/atf_python/sys/netlink/attrs.py:38	E501	PEP8 E501
Error	tests/atf_python/sys/netlink/message.py:22	E501	PEP8 E501
Error	tests/atf_python/sys/netlink/message.py:143	E501	PEP8 E501
Error	tests/atf_python/sys/netlink/message.py:148	E501	PEP8 E501
Error	tests/atf_python/sys/netlink/message.py:169	E501	PEP8 E501
Error	tests/atf_python/sys/netlink/netlink_route.py:457	E501	PEP8 E501
Error	tests/atf_python/sys/netlink/utils.py:35	E701	PEP8 E701
Error	tests/atf_python/sys/netlink/utils.py:36	E701	PEP8 E701
Error	tests/atf_python/sys/netlink/utils.py:37	E701	PEP8 E701
Error	tests/sys/netlink/test_nl_core.py:19	E501	PEP8 E501
Error	tests/sys/netlink/test_nl_core.py:32	E501	PEP8 E501
Error	tests/sys/netlink/test_rtnl_iface.py:41	E501	PEP8 E501
Error	tests/sys/netlink/test_rtnl_iface.py:77	E501	PEP8 E501
Error	tests/sys/netlink/test_rtnl_iface.py:101	E501	PEP8 E501
Error	tests/sys/netlink/test_rtnl_iface.py:117	E501	PEP8 E501
Error	tests/sys/netlink/test_rtnl_iface.py:126	E501	PEP8 E501
Error	tests/sys/netlink/test_rtnl_iface.py:135	E501	PEP8 E501
Error	tests/sys/netlink/test_rtnl_iface.py:156	E501	PEP8 E501
Error	tests/sys/netlink/test_rtnl_iface.py:165	E501	PEP8 E501
Error	tests/sys/netlink/test_rtnl_iface.py:196	E501	PEP8 E501
Error	tests/sys/netlink/test_rtnl_iface.py:205	E501	PEP8 E501
Error	tests/sys/netlink/test_rtnl_iface.py:254	E501	PEP8 E501
Error	tests/sys/netlink/test_rtnl_iface.py:255	E501	PEP8 E501
Error	tests/sys/netlink/test_rtnl_iface.py:257	E501	PEP8 E501
Error	tests/sys/netlink/test_rtnl_iface.py:271	E501	PEP8 E501

Unit

No Test Coverage

Build Status

Buildable 50704
Build 47595: arc lint + arc unit

Event Timeline

melifaro created this revision.Mar 31 2023, 12:53 PM

Herald added subscribers: glebius, ae, imp. · View Herald TranscriptMar 31 2023, 12:53 PM

melifaro requested review of this revision.Mar 31 2023, 12:53 PM

Harbormaster completed remote builds in B50704: Diff 119711.Mar 31 2023, 12:53 PM

melifaro edited the summary of this revision. (Show Details)Mar 31 2023, 12:55 PM

melifaro added reviewers: network, tests.

melifaro added a child revision: D39370: tests: add support for parsing generic netlink families..Mar 31 2023, 3:44 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 1 2023, 7:38 PM

This revision was landed with ongoing or failed builds.

Closed by commit rGfee65b7e21ee: tests: split netlink.py into multiple files to impove maintainability. (authored by melifaro). · Explain Why

This revision was automatically updated to reflect the committed changes.

melifaro added a commit: rGfee65b7e21ee: tests: split netlink.py into multiple files to impove maintainability..

Revision Contents
Changeset List

Path

Size

tests/

atf_python/

sys/

2 lines

net/

2 lines

netlink/

11 lines

287 lines

base_headers.py

65 lines

201 lines

368 lines

netlink_route.py

727 lines

74 lines

sys/

netlink/

test_nl_core.py

4 lines

test_rtnl_iface.py

32 lines

test_rtnl_ifaddr.py

19 lines

test_rtnl_neigh.py

12 lines

test_rtnl_route.py

22 lines

Diff 119711

tests/atf_python/sys/Makefile

Loading...

tests/atf_python/sys/net/Makefile

Loading...

tests/atf_python/sys/net/netlink.py

Loading...

tests/atf_python/sys/netlink/Makefile

Loading...

tests/atf_python/sys/netlink/init.py

Loading...

tests/atf_python/sys/netlink/attrs.py

Loading...

tests/atf_python/sys/netlink/base_headers.py

Loading...

tests/atf_python/sys/netlink/message.py

Loading...

tests/atf_python/sys/netlink/netlink.py

Loading...

tests/atf_python/sys/netlink/netlink_route.py

Loading...

tests/atf_python/sys/netlink/utils.py

Loading...

tests/sys/netlink/test_nl_core.py

Loading...

tests/sys/netlink/test_rtnl_iface.py

Loading...

tests/sys/netlink/test_rtnl_ifaddr.py

Loading...

tests/sys/netlink/test_rtnl_neigh.py

Loading...

tests/sys/netlink/test_rtnl_route.py

Loading...