Paths

Table of Contentst

-
sys/compat/linuxkpi/common/include/linux/
-
compat/
-
linuxkpi/
-
common/
-
include/
-
linux/
-
kernel.h
-
spinlock.h

linuxkpi: Appease -Wunused-but-set-variable warnings from GCC.
ClosedPublic
Actions

Authored by jhb on Mar 30 2023, 11:33 PM.

Details

Reviewers

manu
• hselasky

Commits

rGad83dd2b2b6b: LinuxKPI: Appease -Wunused-but-set-variable warnings from GCC.

Summary

Mark assert dummy variables as __used.

Use a dummy (void) cast of the flags argument passed to spin_unlock_irqrestore so it gets treated as used.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 50686
Build 47577: arc lint + arc unit

Event Timeline

jhb created this revision.Mar 30 2023, 11:33 PM

Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptMar 30 2023, 11:33 PM

jhb requested review of this revision.Mar 30 2023, 11:33 PM

Harbormaster completed remote builds in B50686: Diff 119685.Mar 30 2023, 11:33 PM

jhb added a child revision: D39350: fuse: Remove set but unused cr_gid variable..Mar 30 2023, 11:33 PM

LGTM but fix your commit message to say unused instead of used

This revision is now accepted and ready to land.Mar 31 2023, 5:13 AM

Commit message should start using: "LinuxKPI: "

Looks good!

• hselasky accepted this revision.Mar 31 2023, 9:44 AM

Closed by commit rGad83dd2b2b6b: LinuxKPI: Appease -Wunused-but-set-variable warnings from GCC. (authored by jhb). · Explain WhyMar 31 2023, 5:59 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGad83dd2b2b6b: LinuxKPI: Appease -Wunused-but-set-variable warnings from GCC..

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

kernel.h

2 lines

spinlock.h

1 line

Diff 119685

View Options

sys/compat/linuxkpi/common/include/linux/kernel.h

Context not available.
	*/	*/
	arm_smccc_1_0 hvc	arm_smccc_1_0 hvc
	arm_smccc_1_0 smc	arm_smccc_1_0 smc
		/* arm_smccc_1_2_hvc(const struct arm_smccc_1_2_regs *args,
		struct arm_smccc_1_2_regs res) /
		andrewUnsubmitted Done Inline Actions You can remove this comment & replace it with a newline to seperate the above from the 1.2 macro. andrew: You can remove this comment & replace it with a newline to seperate the above from the 1.2…
		.macro arm_smccc_1_2 insn
		ENTRY(arm_smccc_1_2_\insn)
		stp x1, x19, [sp, #-16]!
		mov x19, x0
		ldp x0, x1, [x19, #16 * 0]
		ldp x2, x3, [x19, #16 * 1]
		ldp x4, x5, [x19, #16 * 2]
		ldp x6, x7, [x19, #16 * 3]
		ldp x8, x9, [x19, #16 * 4]
		andrewUnsubmitted Done Inline Actions Can you rebase this past R10:48a7e53db78293ba2723cecfb3a3d5d23ea8e44d & update to be a macro so we can also add `smc` support. andrew: Can you rebase this past R10:48a7e53db78293ba2723cecfb3a3d5d23ea8e44d & update to be a macro so…
		ldp x10, x11, [x19, #16 * 5]
		ldp x12, x13, [x19, #16 * 6]
		ldp x14, x15, [x19, #16 * 7]
		ldp x16, x17, [x19, #16 * 8]
		hvc #0
		andrewUnsubmitted Done Inline Actions `\insn #0` andrew: `\insn #0`
		ldr x19, [sp]
		cbz x19, 1f
		stp x0, x1, [x19, #16 * 0]
		stp x2, x3, [x19, #16 * 1]
		lwhsuUnsubmitted Done Inline Actions Why two spaces between `,` and `[`? for those 3 lines? lwhsu: Why two spaces between `,` and `[`? for those 3 lines?
		stp x4, x5, [x19, #16 * 2]
		stp x6, x7, [x19, #16 * 3]
		stp x8, x9, [x19, #16 * 4]
		stp x10, x11, [x19, #16 * 5]
		stp x12, x13, [x19, #16 * 6]
		stp x14, x15, [x19, #16 * 7]
		stp x16, x17, [x19, #16 * 8]
		ldp xzr, x19, [sp], #16
		1: ret
		END(arm_smccc_1_2\insn)
		.endm
		/* int arm_smccc_1_2_(const struct arm_smccc_1_2_regs args,
		lwhsuUnsubmitted Done Inline Actions Also those 3 lines. lwhsu: Also those 3 lines.
		lwhsuUnsubmitted Not Done Inline Actions Small nit: trailing white space. lwhsu: Small nit: trailing white space.
		* struct arm_smccc_1_2_regs *res)
		*/
		arm_smccc_1_2 hvc
		arm_smccc_1_2 smc
Context not available.