mlxfw: fix potential NULL pointer dereference
ClosedPublic
Actions

Authored by vangyzen on Mar 30 2023, 10:28 PM.

Tags

None

Referenced Files

	F156581991: D39348.id.diff
	Thu, May 14, 8:35 PM

	F156579686: D39348.id119683.diff
	Thu, May 14, 8:11 PM

	F156567572: D39348.id119851.diff
	Thu, May 14, 5:44 PM

	Unknown Object (File)
	Mon, May 11, 9:46 PM

	Unknown Object (File)
	Sun, May 10, 2:32 AM

	Unknown Object (File)
	Thu, Apr 23, 11:41 PM

	Unknown Object (File)
	Mon, Apr 20, 5:43 PM

	Unknown Object (File)
	Sun, Apr 19, 12:40 PM

Subscribers

Details

Reviewers

slavash
• hselasky
kib

Commits

rGecaeac805b04: mlxfw: fix potential NULL pointer dereference

Summary

Reported by: Coverity
MFC after: 1 week
Sponsored by: Dell EMC Isilon

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 50685
Build 47576: arc lint + arc unit

Event Timeline

vangyzen created this revision.Mar 30 2023, 10:28 PM

Herald added subscribers: dab, badger, imp. · View Herald TranscriptMar 30 2023, 10:28 PM

vangyzen requested review of this revision.Mar 30 2023, 10:28 PM

Harbormaster completed remote builds in B50685: Diff 119683.Mar 30 2023, 10:28 PM

It's not clear to me whether this is actually possible or just theoretical.

guest-patmaddox added a subscriber: guest-patmaddox.Mar 31 2023, 5:55 AM

Adding Konstantin.

--HPS

I do not object. OTOH in-kernel parser definitely not prepared to malformed mfa packages anyway.

This revision is now accepted and ready to land.Mar 31 2023, 11:30 PM

Closed by commit rGecaeac805b04: mlxfw: fix potential NULL pointer dereference (authored by vangyzen). · Explain WhyApr 4 2023, 7:29 PM

This revision was automatically updated to reflect the committed changes.

vangyzen added a commit: rGecaeac805b04: mlxfw: fix potential NULL pointer dereference.

guest-patmaddox removed a subscriber: guest-patmaddox.Jul 29 2023, 5:38 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

mlxfw/

mlxfw_mfa2_tlv_multi.c

2 lines

Diff 119683

View Options

sys/dev/mlxfw/mlxfw_mfa2_tlv_multi.c

mlxfw: fix potential NULL pointer dereferenceClosedPublicActions