RFC populate DT_DEBUG on MIPS if PT_DYNAMIC is writable
ClosedPublic
Actions

Authored by emaste on Jan 5 2016, 1:45 AM.

Details

Reviewers

kib

Commits

rS293201: rtld: populate DT_DEBUG iff DYNAMIC segment is writable

Summary

See http://reviews.llvm.org/D15775 where there's a suggestion that lld include DT_DEBUG also on MIPS. Then this change will allow rtld to populate DT_DEBUG, and lldb can then use DT_DEBUG if set, and eventually we can remove one MIPS special-case. Review posted for discussion; there may be a better implementation.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste updated this revision to Diff 11935.Jan 5 2016, 1:45 AM

emaste retitled this revision from to RFC populate DT_DEBUG on MIPS if PT_DYNAMIC is writable.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste added a reviewer: kib.

emaste added subscribers: adrian, davide.

Why do you need #ifdef mips around the writable_dynamic handling ?

In D4791#101766, @kib wrote:

Why do you need #ifdef mips around the writable_dynamic handling ?

I don't need it, I suppose, but PT_DYNAMIC is specified to be writable on all other platforms and I didn't want to introduce an unnecessary test.

In D4791#101800, @emaste wrote:

I don't need it, I suppose, but PT_DYNAMIC is specified to be writable on all other platforms and I didn't want to introduce an unnecessary test.

The test is so cheap that I do not see much reason to #ifdef it.