Differential D39146

amd64: properly recalculate mitigations knobs after resume
ClosedPublic
Actions

Authored by kib on Mar 17 2023, 7:51 PM.

Tags

None

Referenced Files

	F157798339: D39146.id119052.diff
	Mon, May 25, 7:44 AM

	F157769596: D39146.id.diff
	Mon, May 25, 12:00 AM

	F157741211: D39146.id119027.diff
	Sun, May 24, 5:40 PM

	Unknown Object (File)
	Thu, May 21, 1:58 PM

	Unknown Object (File)
	Sun, May 17, 11:42 PM

	Unknown Object (File)
	Sun, May 17, 11:42 PM

	Unknown Object (File)
	Sun, May 17, 11:42 PM

	Unknown Object (File)
	Fri, May 15, 12:14 PM

Subscribers

Details

Reviewers

markj
emaste

Commits

rG2b4b3789f877: acpi_wakeup.c: apply the reviewer' editorial corrections to the comment text.
rG02904a06c76b: amd64: properly recalculate mitigations knobs after resume

Summary

Revision r333125 AKA 986c4ca38772f72 forced clear cpu_stdext_feature3
on suspend, since at that time microcode update was not reloaded
early on resume. Then, revision 8405c63dadaf started re-reading
cpu_stdext_feature3 again. Since modern CPUs do not require mitigations
from the Skylake era, this went unnoticed for some time.

Keep zeroing cpu_stdext_feature3 on suspend, but re-read it in more
controlled way on resume after microcode is reloaded, and recalculate
active workarounds based on actual microcode capabilities.

Reported and tested by: romain

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Mar 17 2023, 7:51 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 17 2023, 7:51 PM

kib requested review of this revision.Mar 17 2023, 7:51 PM

emaste accepted this revision.Mar 17 2023, 8:10 PM

This revision is now accepted and ready to land.Mar 17 2023, 8:10 PM

I do not have commit 8405c63dadaf in my tree. Commit 050f5a8405c63 probably?

sys/amd64/acpica/acpi_wakeup.c
294
295

Closed by commit rG02904a06c76b: amd64: properly recalculate mitigations knobs after resume (authored by kib). · Explain WhyMar 18 2023, 3:41 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG02904a06c76b: amd64: properly recalculate mitigations knobs after resume.

kib marked 2 inline comments as done.Mar 18 2023, 3:45 PM

kib added a commit: rG2b4b3789f877: acpi_wakeup.c: apply the reviewer' editorial corrections to the comment text..Mar 18 2023, 3:49 PM

Revision Contents
Changeset List

Path

Size

sys/

amd64/

acpica/

14 lines

amd64/

2 lines

Diff 119052

sys/amd64/acpica/acpi_wakeup.c

Loading...

sys/amd64/amd64/initcpu.c

Loading...