Page MenuHomeFreeBSD
Differential D38899

arm64/disassem.c: Fix formatting
ClosedPublic
Actions

Authored by koliagogsadze_gmail.com on Mar 3 2023, 6:58 PM.
Tags
None
Referenced Files
F109923144: D38899.id119531.diff
Tue, Feb 11, 6:57 AM
F109922893: D38899.id118280.diff
Tue, Feb 11, 6:52 AM
F109922637: D38899.id121041.diff
Tue, Feb 11, 6:46 AM
F109901657: D38899.diff
Mon, Feb 10, 11:26 PM
Unknown Object (File)
Thu, Feb 6, 8:46 AM
Unknown Object (File)
Fri, Jan 31, 11:01 PM
Unknown Object (File)
Nov 21 2024, 11:28 PM
Unknown Object (File)
Nov 10 2024, 3:00 AM
View All 64 Files
Subscribers
andrew
emaste
imp

Details

Reviewers
mhorne
manu
Commits
rG8a226e8cabee: arm64/disassem.c: style and formatting
rG5b61ad4b005d: arm64/disassem.c: style and formatting

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 50136
Build 47028: arc lint + arc unit

Event Timeline

koliagogsadze_gmail.com created this revision.Mar 3 2023, 6:58 PM
Herald added a reviewer: manu. · View Herald TranscriptMar 3 2023, 6:58 PM
Herald added subscribers: emaste, andrew, imp. · View Herald Transcript
koliagogsadze_gmail.com requested review of this revision.Mar 3 2023, 6:58 PM
Harbormaster completed remote builds in B50136: Diff 118280.Mar 3 2023, 6:58 PM
mhorne added a comment.Mar 27 2023, 5:36 PM

Two small things to fix, but this looks good to me. I will wait for the follow-up changes before committing anything.

sys/arm64/arm64/disassem.c
87

Drop this extra blank line.

468

This line was indented correctly already. From the style(9) page:

Indentation is an 8 character tab. Second level indents are four spaces.
koliagogsadze_gmail.com updated this revision to Diff 119530.Mar 27 2023, 10:40 PM
This comment was removed by koliagogsadze_gmail.com.
Harbormaster completed remote builds in B50609: Diff 119530.Mar 27 2023, 10:40 PM
koliagogsadze_gmail.com updated this revision to Diff 119531.Mar 27 2023, 10:52 PM

Remove extra line and fix indentation

Harbormaster completed remote builds in B50610: Diff 119531.Mar 27 2023, 10:52 PM
koliagogsadze_gmail.com marked 2 inline comments as done.Mar 27 2023, 10:55 PM
mhorne accepted this revision.Mar 28 2023, 6:41 PM
This revision is now accepted and ready to land.Mar 28 2023, 6:41 PM
Closed by commit rG5b61ad4b005d: arm64/disassem.c: style and formatting (authored by koliagogsadze_gmail.com, committed by mhorne). · Explain WhyApr 25 2023, 8:24 PM
This revision was automatically updated to reflect the committed changes.
mhorne added a commit: rG5b61ad4b005d: arm64/disassem.c: style and formatting.
mhorne added a commit: rG8a226e8cabee: arm64/disassem.c: style and formatting.Jun 9 2023, 7:58 PM

Revision Contents
Changeset List

PathSize
sys/
arm64/
arm64/
78 lines

Diff 118280

View Options

sys/arm64/arm64/disassem.c

Loading...