Differential D38832

net80211: define mask for ss_flags rather than using hardcoded 0xfff
ClosedPublic
Actions

Authored by bz on Feb 28 2023, 10:32 PM.

Tags

None

Referenced Files

	F84169199: D38832.id.diff
	Mon, May 20, 8:09 AM

	Unknown Object (File)
	Fri, May 3, 4:49 AM

	Unknown Object (File)
	Sun, Apr 21, 3:02 AM

	Unknown Object (File)
	Apr 5 2024, 9:39 AM

	Unknown Object (File)
	Dec 21 2023, 3:39 PM

	Unknown Object (File)
	Dec 20 2023, 8:29 AM

	Unknown Object (File)
	Dec 16 2023, 11:58 AM

	Unknown Object (File)
	Dec 12 2023, 2:54 PM

View All 25 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rGc6f7abeaeb5b: net80211: define mask for ss_flags rather than using hardcoded 0xfff
rG3346164ce844: net80211: define mask for ss_flags rather than using hardcoded 0xfff

Summary

scan state ss_flags in two places cut off the "internal" GOTPICK
options. Replace the hardcoded 0xfff with a defined mask.
Note that "internal" flags is confusing as we also supplement the
the 16bit by another 16bit of "internal flags" passed around but
comaparing to GOTPICK never stored to my understanding.

No functional change.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 50072
Build 46964: arc lint + arc unit

Event Timeline

bz created this revision.Feb 28 2023, 10:32 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptFeb 28 2023, 10:32 PM

bz requested review of this revision.Feb 28 2023, 10:32 PM

Harbormaster completed remote builds in B50072: Diff 118107.Feb 28 2023, 10:32 PM

adrian accepted this revision.Feb 28 2023, 11:32 PM

This revision is now accepted and ready to land.Feb 28 2023, 11:32 PM

Closed by commit rG3346164ce844: net80211: define mask for ss_flags rather than using hardcoded 0xfff (authored by bz). · Explain WhyMar 14 2023, 10:20 PM

This revision was automatically updated to reflect the committed changes.

bz added a commit: rG3346164ce844: net80211: define mask for ss_flags rather than using hardcoded 0xfff.

bz added a commit: rGc6f7abeaeb5b: net80211: define mask for ss_flags rather than using hardcoded 0xfff.Jun 26 2023, 12:08 PM

Revision Contents
Changeset List

Path

Size

sys/

net80211/

ieee80211_scan.h

1 line

ieee80211_scan_sw.c

5 lines

Diff 118107

sys/net80211/ieee80211_scan.h

Loading...

sys/net80211/ieee80211_scan_sw.c

Loading...