stat.h does not exist
ClosedPublic
Actions

Authored by emaste on Feb 24 2023, 2:46 PM.

Details

Reviewers

brooks
jrtc27

Commits

rG2d415b019617: tools/build: Hide spurious errors if sys/stat.h does not exist
rGc5e54e56e68a: tools/build: Hide spurious errors if sys/stat.h does not exist

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste requested review of this revision.Feb 24 2023, 2:46 PM

emaste created this revision.

Seems fine, though given we're willing to pay the cost of an exec, wrapping the thing in .if exists(${HOST_INCLUDE_ROOT}/sys/stat.h) might be tidier.

brooks accepted this revision.Feb 24 2023, 7:27 PM

This revision is now accepted and ready to land.Feb 24 2023, 7:27 PM

use .if exists as suggested by @brooks

This revision now requires review to proceed.Feb 24 2023, 8:48 PM

brooks accepted this revision.Feb 24 2023, 10:48 PM

This revision is now accepted and ready to land.Feb 24 2023, 10:48 PM

Closed by commit rGc5e54e56e68a: tools/build: Hide spurious errors if sys/stat.h does not exist (authored by emaste). · Explain WhyMar 2 2023, 1:00 AM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rGc5e54e56e68a: tools/build: Hide spurious errors if sys/stat.h does not exist.

Herald added a subscriber: imp. · View Herald TranscriptMar 2 2023, 1:00 AM

emaste added a commit: rG2d415b019617: tools/build: Hide spurious errors if sys/stat.h does not exist.Mar 6 2023, 1:51 PM

Revision Contents
Changeset List

Path

Size

tools/

build/

Makefile

4 lines

Diff 117893

View Options

tools/build: Hide spurious errors if sys/stat.h does not existClosedPublicActions