security/0d1n: fix build
ClosedPublic
Actions

Authored by fuz on Feb 22 2023, 11:58 AM.

Details

Reviewers

eduardo
flo
lwhsu

Commits

R11:ffba4d2517e8: security/0d1n: fix build

Summary

security/0d1n: fix build

 - convert static REINPLACE_CMD to patch files as per policy
 - remove remaining <alloca.h> uses
 - patch getopt_long use on targets where char is unsigned
 - work around missing __GNUC_PREREQ macro
 - fix other missing includes
 - update pkg-plist to what the maintainer intended to pack
 - patch /opt/0d1n to ${DATADIR} in the relevant files

PR:		269717
Fixes:		88dd085ff7851bb2906039d97a81857fe6d8b2e3
Approved by:	portmgr (build fix)
Approved by:	... (mentor)

A fix for a botched patch, incorporating bits of a maintainer patch
that were omitted from the commit by accident most likely. These
bits were however changed and expanded to improve policy compliance
and to fix some more problems.

Test Plan

Tested with Poudriere on amd64 i386 FreeBSD 12.4 13.1
Arm64 pending. See http://fuz.su/~fuz/freebsd/batch4 for logs.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 49962
Build 46854: arc lint + arc unit

Event Timeline

fuz created this revision.Feb 22 2023, 11:58 AM

Herald added a subscriber: mat. · View Herald TranscriptFeb 22 2023, 11:58 AM

fuz requested review of this revision.Feb 22 2023, 11:58 AM

Harbormaster completed remote builds in B49951: Diff 117748.Feb 22 2023, 11:58 AM

Mark project as dual licensed GPLv3/BSD3CLAUSE. Upstream
has since removed the GPLv3 license file. Also define
LICENSE_FILE_... as recommended by policy.

Harbormaster completed remote builds in B49962: Diff 117763.Feb 22 2023, 2:11 PM

Approved. I realize that this is one more of those not documented but usually we do it this way things. When we use blanket approval it's often noted as such. i.e. portmgr (blanket, build fix), otherwise it looks like portmgr actively approved this commit, which I *think* the did not?

This revision is now accepted and ready to land.Feb 23 2023, 7:33 PM

Thanks, will add the word “blanket” on commit.

Closed by commit R11:ffba4d2517e8: security/0d1n: fix build (authored by fuz). · Explain WhyFeb 24 2023, 8:52 AM

This revision was automatically updated to reflect the committed changes.

fuz added a commit: R11:ffba4d2517e8: security/0d1n: fix build.