Page MenuHomeFreeBSD
Differential D38715

linux(4): Fixup the interface name translation in netlink
ClosedPublic
Actions

Authored by dchagin on Feb 21 2023, 10:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 22, 8:12 AM
Unknown Object (File)
Tue, Apr 21, 7:49 PM
Unknown Object (File)
Fri, Apr 17, 8:13 AM
Unknown Object (File)
Tue, Apr 7, 10:04 AM
Unknown Object (File)
Mon, Apr 6, 7:15 PM
Unknown Object (File)
Sun, Apr 5, 10:39 AM
Unknown Object (File)
Mon, Mar 30, 5:56 PM
Unknown Object (File)
Sun, Mar 29, 4:19 PM
View All Files
Subscribers
imp

Details

Reviewers
melifaro
jhibbits
Commits
rG9006cd0fd543: linux(4): Fixup the interface name translation in netlink
rG123ca9ab1189: linux(4): Fixup the interface name translation in netlink
rGe55e4a6ba3f4: linux(4): Fixup the interface name translation in netlink
Summary

Netlink should translate a FreeBSD interface name to a Linux interface name.

MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 49946
Build 46838: arc lint + arc unit

Event Timeline

dchagin created this revision.Feb 21 2023, 10:30 PM
Herald added a subscriber: imp. · View Herald TranscriptFeb 21 2023, 10:30 PM
dchagin requested review of this revision.Feb 21 2023, 10:30 PM
Harbormaster completed remote builds in B49937: Diff 117719.Feb 21 2023, 10:30 PM
dchagin added reviewers: melifaro, jhibbits.Feb 21 2023, 10:35 PM
melifaro added inline comments.Feb 22 2023, 8:35 AM
sys/compat/linux/linux_netlink.c
255

You need to check the message type as well, as this value is only valud for RTM_<NEW|DEL|GET>LINK.

Also - for readability I’d consider moving attribute rewriting to a separate function. This will help keep copy-all_nla function readable when more translations are added

dchagin updated this revision to Diff 117743.Feb 22 2023, 10:09 AM

done

Harbormaster completed remote builds in B49946: Diff 117743.Feb 22 2023, 10:09 AM
dchagin updated this revision to Diff 117764.Feb 22 2023, 2:40 PM

Check nlmsg_type

Harbormaster completed remote builds in B49963: Diff 117764.Feb 22 2023, 2:40 PM
melifaro accepted this revision.Feb 22 2023, 2:52 PM

LGTM

sys/compat/linux/linux_netlink.c
241

Nit: worth describing the return codes here.

252

I'd explicitly cast it to int, or make it a branch, to help reader understand the return codes.

254–264
This revision is now accepted and ready to land.Feb 22 2023, 2:52 PM
dchagin updated this revision to Diff 117778.Feb 22 2023, 6:21 PM

done

This revision now requires review to proceed.Feb 22 2023, 6:21 PM
Harbormaster completed remote builds in B49967: Diff 117778.Feb 22 2023, 6:21 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 23 2023, 8:01 AM
Closed by commit rGe55e4a6ba3f4: linux(4): Fixup the interface name translation in netlink (authored by dchagin). · Explain Why
This revision was automatically updated to reflect the committed changes.
dchagin added a commit: rGe55e4a6ba3f4: linux(4): Fixup the interface name translation in netlink.
dchagin added a commit: rG123ca9ab1189: linux(4): Fixup the interface name translation in netlink.Feb 26 2023, 8:13 AM
dchagin added a commit: rG9006cd0fd543: linux(4): Fixup the interface name translation in netlink.Feb 27 2023, 6:17 PM

Revision Contents
Changeset List

PathSize
sys/
compat/
linux/
26 lines

Diff 117743

View Options

sys/compat/linux/linux_netlink.c

Loading...