Page MenuHomeFreeBSD
Differential D38645

tarfs: Really prevent descending into a non-directory.
ClosedPublic
Actions

Authored by des on Feb 16 2023, 9:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 7, 10:24 AM
Unknown Object (File)
Fri, Sep 4, 2:35 PM
Unknown Object (File)
Thu, Sep 3, 3:56 PM
Unknown Object (File)
Mon, Aug 31, 2:47 PM
Unknown Object (File)
Sat, Aug 22, 6:08 AM
Unknown Object (File)
Sat, Aug 15, 10:26 AM
Unknown Object (File)
Thu, Aug 13, 4:54 PM
Unknown Object (File)
Thu, Aug 13, 4:54 PM
View All Files
Subscribers
cy
imp

Details

Reviewers
kib
Group Reviewers
Klara
Commits
rGd481dcee72a0: tarfs: Really prevent descending into a non-directory.
Summary

The previous fix was incorrect: we need to verify that the current node, if it exists, is not a directory, but we were checking the parent node instead. Address this, add more tests, and fix the test cleanup routines.

PR: 269519, 269561
Fixes: ae6cff89738b
Sponsored by: Juniper Networks, Inc.
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 49858
Build 46749: arc lint + arc unit

Revision Contents
Changeset List

PathSize
sys/
fs/
tarfs/
17 lines
tests/
sys/
fs/
tarfs/
87 lines

Diff 117473

View Options

sys/fs/tarfs/tarfs_vfsops.c

Loading...
View Options

tests/sys/fs/tarfs/tarfs_test.sh

Loading...