Differential D38645

tarfs: Really prevent descending into a non-directory.
ClosedPublic
Actions

Authored by des on Feb 16 2023, 9:00 PM.

Details

Reviewers

kib

Group Reviewers

Klara

Commits

rGd481dcee72a0: tarfs: Really prevent descending into a non-directory.

Summary

The previous fix was incorrect: we need to verify that the current node, if it exists, is not a directory, but we were checking the parent node instead. Address this, add more tests, and fix the test cleanup routines.

PR: 269519, 269561
Fixes: ae6cff89738b
Sponsored by: Juniper Networks, Inc.
Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 49858
Build 46749: arc lint + arc unit

Event Timeline

des created this revision.Feb 16 2023, 9:00 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 16 2023, 9:00 PM

des requested review of this revision.Feb 16 2023, 9:00 PM

Harbormaster completed remote builds in B49858: Diff 117473.Feb 16 2023, 9:00 PM

Fix test declarations.

Harbormaster completed remote builds in B49859: Diff 117475.Feb 16 2023, 9:06 PM

cy added a subscriber: cy.Feb 16 2023, 9:14 PM

kib accepted this revision.Feb 17 2023, 5:00 AM

This revision is now accepted and ready to land.Feb 17 2023, 5:00 AM

Closed by commit rGd481dcee72a0: tarfs: Really prevent descending into a non-directory. (authored by des). · Explain WhyFeb 20 2023, 9:30 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rGd481dcee72a0: tarfs: Really prevent descending into a non-directory..

Revision Contents
Changeset List

Path

Size

sys/

fs/

tarfs/

tarfs_vfsops.c

17 lines

tests/

sys/

fs/

tarfs/

tarfs_test.sh

87 lines

Diff 117473

View Options

sys/fs/tarfs/tarfs_vfsops.c