security/pam_fprint: revive port pam_fprint is a simple PAM module which uses libfprint's fingerprint processing and verification functionality for authentication. In other words, instead of seeing a password prompt, you're asked to scan your fingerprint. Submitter becomes maintainer. Is already maintainer of other ports. PR: 269554 Approved by: ... (mentor)
Details
- Reviewers
eduardo flo - Commits
- R11:cae60e628488: security/pam_fprint: revive port
Tested with Poudriere on i386 amd64 FreeBSD 12.4 13.1. Arm64 tests pending.
See test results at: http://fuz.su/~fuz/freebsd/batch2
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 49840 Build 46731: arc lint + arc unit
Event Timeline
security/pam_fprint/Makefile | ||
---|---|---|
2 | This should probably be DISTVERSION? |
I have submitted the patch as I received it from the maintainer. I can change it to DISTVERSION for the commit if you want.
Yeah I think that's best, we as committers are expected to fix such minor issues before committing. You can send this back to the submitter, and let them fix it, or just fix it and commit the port with a comment "committed with minor changes" or something like that.
Approved
A side note, from a security perspective I don't think it's a very good idea to re-import a 15 year old PAM module that seems to be unmaintained upstream. But i could not find any CVEs or known vulns.
The module and underlying library are maintained by the Freedesktop project, but have gained a mandatory systemd dependency in the meanwhile. Hence re-adding this one from the old upstream before that happened.