Page MenuHomeFreeBSD

security/pam_fprint: revive port
ClosedPublic

Authored by fuz on Feb 16 2023, 1:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 15, 6:59 PM
Unknown Object (File)
Wed, Apr 10, 12:46 PM
Unknown Object (File)
Wed, Apr 10, 12:34 PM
Unknown Object (File)
Wed, Apr 10, 12:16 PM
Unknown Object (File)
Feb 22 2024, 4:52 AM
Unknown Object (File)
Jan 12 2024, 4:36 AM
Unknown Object (File)
Dec 24 2023, 6:08 PM
Unknown Object (File)
Dec 22 2023, 11:08 PM
Subscribers

Details

Summary
security/pam_fprint: revive port

pam_fprint is a simple PAM module which uses libfprint's fingerprint
processing and verification functionality for authentication. In other
words, instead of seeing a password prompt, you're asked to scan your
fingerprint.

Submitter becomes maintainer.  Is already maintainer of other ports.

PR:		269554
Approved by:	... (mentor)
Test Plan

Tested with Poudriere on i386 amd64 FreeBSD 12.4 13.1. Arm64 tests pending.
See test results at: http://fuz.su/~fuz/freebsd/batch2

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 49840
Build 46731: arc lint + arc unit

Event Timeline

fuz requested review of this revision.Feb 16 2023, 1:04 PM
security/pam_fprint/Makefile
2

This should probably be DISTVERSION?

I have submitted the patch as I received it from the maintainer. I can change it to DISTVERSION for the commit if you want.

In D38628#879480, @fuz wrote:

I have submitted the patch as I received it from the maintainer. I can change it to DISTVERSION for the commit if you want.

Yeah I think that's best, we as committers are expected to fix such minor issues before committing. You can send this back to the submitter, and let them fix it, or just fix it and commit the port with a comment "committed with minor changes" or something like that.

Approved

A side note, from a security perspective I don't think it's a very good idea to re-import a 15 year old PAM module that seems to be unmaintained upstream. But i could not find any CVEs or known vulns.

This revision is now accepted and ready to land.Feb 16 2023, 9:54 PM

The module and underlying library are maintained by the Freedesktop project, but have gained a mandatory systemd dependency in the meanwhile. Hence re-adding this one from the old upstream before that happened.