Page MenuHomeFreeBSD
Differential D38560

ofed: Mechanically convert to IfAPI
ClosedPublic
Actions

Authored by jhibbits on Feb 13 2023, 6:43 PM.
Tags
None
Referenced Files
F175338773: D38560.diff
Sat, Oct 10, 2:49 AM
Unknown Object (File)
Wed, Sep 30, 11:51 PM
Unknown Object (File)
Sun, Sep 20, 9:26 AM
Unknown Object (File)
Sep 10 2026, 6:23 AM
Unknown Object (File)
Sep 2 2026, 2:33 PM
Unknown Object (File)
Sep 2 2026, 12:59 PM
Unknown Object (File)
Sep 2 2026, 12:59 PM
Unknown Object (File)
Aug 30 2026, 4:44 PM
View All Files
Subscribers
imp

Details

Reviewers
glebius
• hselasky
Group Reviewers
network
Commits
rG3e142e07675b: ofed: Mechanically convert to IfAPI
Summary

Because of the intricacies of this code it wasn't purely scripted, but
instead hand-mechanical.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 49742
Build 46632: arc lint + arc unit

Event Timeline

jhibbits created this revision.Feb 13 2023, 6:43 PM
Herald added a subscriber: imp. · View Herald TranscriptFeb 13 2023, 6:43 PM
jhibbits requested review of this revision.Feb 13 2023, 6:43 PM
Harbormaster completed remote builds in B49742: Diff 117111.Feb 13 2023, 6:43 PM
jhibbits updated this revision to Diff 119349.Mar 23 2023, 5:48 PM

Update to use the new if_iter API. Remove rest of struct ifnet uses in the code.

Harbormaster completed remote builds in B50546: Diff 119349.Mar 23 2023, 5:48 PM
• hselasky accepted this revision.Mar 23 2023, 6:33 PM

Looks pretty good to me. If any issues pop up I know one commit to look at :-)

One idea that comes to mind:
if_getdrvflags(dev) & IFF_DRV_OACTIVE

Instead of doing bit-tests, maybe we should convert those flags to enums, so that we query a flag based on an enum. Then there can be more than 32-64 flags ...

This revision is now accepted and ready to land.Mar 23 2023, 6:33 PM
Closed by commit rG3e142e07675b: ofed: Mechanically convert to IfAPI (authored by jhibbits). · Explain WhyMar 24 2023, 3:49 PM
This revision was automatically updated to reflect the committed changes.
jhibbits added a commit: rG3e142e07675b: ofed: Mechanically convert to IfAPI.

Revision Contents
Changeset List

PathSize
sys/
ofed/
drivers/
infiniband/
core/
88 lines
26 lines
4 lines
74 lines
2 lines
164 lines
ulp/
ipoib/
10 lines
24 lines
16 lines
201 lines
20 lines
8 lines
include/
rdma/
31 lines

Diff 117111

View Options

sys/ofed/drivers/infiniband/core/ib_addr.c

Loading...
View Options

sys/ofed/drivers/infiniband/core/ib_cache.c

Loading...
View Options

sys/ofed/drivers/infiniband/core/ib_cm.c

Loading...
View Options

sys/ofed/drivers/infiniband/core/ib_cma.c

Loading...
View Options

sys/ofed/drivers/infiniband/core/ib_device.c

Loading...
View Options

sys/ofed/drivers/infiniband/core/ib_roce_gid_mgmt.c

Loading...
View Options

sys/ofed/drivers/infiniband/ulp/ipoib/ipoib.h

Loading...
View Options

sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_cm.c

Loading...
View Options

sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_ib.c

Loading...
View Options

sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_main.c

Loading...
View Options

sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_multicast.c

Loading...
View Options

sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_verbs.c

Loading...
View Options

sys/ofed/include/rdma/ib_addr.h

Loading...