Page MenuHomeFreeBSD
Differential D38221

devel/arcanist-lib: Unbreak "arc list" with php82
AbandonedPublic
Actions

Authored by markj on Jan 27 2023, 3:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 24, 8:22 AM
Unknown Object (File)
Tue, Dec 23, 3:07 AM
Unknown Object (File)
Nov 28 2025, 7:10 PM
Unknown Object (File)
Nov 21 2025, 3:22 AM
Unknown Object (File)
Nov 21 2025, 3:13 AM
Unknown Object (File)
Nov 21 2025, 3:11 AM
Unknown Object (File)
Oct 28 2025, 4:49 AM
Unknown Object (File)
Oct 27 2025, 5:20 AM
View All 65 Files
Subscribers
mat

Details

Reviewers
grembo
• karels
jrm
Summary

In some cases it's possible for arcanist to attempt to call strncmp()
with a null parameter. It seems that this is not allowed in php82, and
causes "arc list" to exit with an exception if the user happens to have
any open differential revisions with a null sourcePath attribute.

Add a patch to work around the problem: if there's no sourcePath, just
treat the source as being different from the current repository.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 49260
Build 46150: arc lint + arc unit

Event Timeline

markj created this revision.Jan 27 2023, 3:30 PM
Herald added a subscriber: mat. · View Herald TranscriptJan 27 2023, 3:30 PM
markj requested review of this revision.Jan 27 2023, 3:30 PM
Harbormaster completed remote builds in B49260: Diff 115924.Jan 27 2023, 3:30 PM
• karels added a comment.Jan 27 2023, 3:56 PM

Looks plausible to me, but I don't know php at all.

jrm added a comment.Jan 27 2023, 4:04 PM

Looks good to me. Builds and applies fine with php81, which is currently the default PHP version in ports.

• karels added a comment.Jan 27 2023, 4:26 PM

fwiw, there are separate archanist-php8[012]-* ports, and I arbitrarily chose 82.

jrm added a comment.Jan 27 2023, 4:57 PM
In D38221#868793, @karels wrote:

fwiw, there are separate archanist-php8[012]-* ports, and I arbitrarily chose 82.

There is just one port (two if you count devel/arcanist and devel/arcanist-lib). Flavors is what gives support for different php versions.

% make -C/usr/ports/devel/arcanist-lib -VFLAVORS
php81 php80 php82
• karels added a comment.Jan 27 2023, 6:07 PM

Sorry, I should have said "packages"; I didn't realize that they weren't always 1:1 with ports.

grembo added a comment.Jan 27 2023, 6:20 PM

@markj Thanks, I'll look into it

grembo added a comment.Jan 31 2023, 6:58 PM

@markj @jrm I just committed be146a923dbda66f50c6b04b406da790837f6287 (cgit link) which addresses the issue in a more generic fashion (since we had these kinds of errors pop up over and over again). Even though I tested this locally and it seems to work as expected, it would be great if you could verify this at your end as well.

markj abandoned this revision.Feb 1 2023, 4:33 PM
In D38221#870150, @grembo wrote:

@markj @jrm I just committed be146a923dbda66f50c6b04b406da790837f6287 (cgit link) which addresses the issue in a more generic fashion (since we had these kinds of errors pop up over and over again). Even though I tested this locally and it seems to work as expected, it would be great if you could verify this at your end as well.

Thanks! This fixes the problem that I was able to reproduce.

jrm added a comment.Feb 1 2023, 5:39 PM
In D38221#870150, @grembo wrote:

@markj @jrm I just committed be146a923dbda66f50c6b04b406da790837f6287 (cgit link) which addresses the issue in a more generic fashion (since we had these kinds of errors pop up over and over again). Even though I tested this locally and it seems to work as expected, it would be great if you could verify this at your end as well.

Also fixes the problem I was seeing before 3b715073072794942506d27d72b2b23551c4fd30. Thank you.

Revision Contents
Changeset List

PathSize
devel/
arcanist-lib/
files/
25 lines

Diff 115924

View Options

devel/arcanist-lib/files/patch-src_workflow_ArcanistListWorkflow.php

Loading...