Differential D38114

Handle ERELOOKUP from VOP_FSYNC()
ClosedPublic
Actions

Authored by kib on Jan 18 2023, 9:12 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Apr 20, 2:27 AM

	Unknown Object (File)
	Mon, Apr 20, 2:27 AM

	Unknown Object (File)
	Sun, Apr 12, 6:15 PM

	Unknown Object (File)
	Sat, Apr 11, 12:48 PM

	Unknown Object (File)
	Sat, Apr 11, 12:33 PM

	Unknown Object (File)
	Fri, Apr 10, 6:25 AM

	Unknown Object (File)
	Sun, Apr 5, 10:53 PM

	Unknown Object (File)
	Sun, Apr 5, 5:39 PM

Subscribers

Details

Reviewers

markj
mckusick

Commits

rG6189672e6008: Handle ERELOOKUP from VOP_FSYNC() in several other places

Summary

We need to repeat the operation if the vnode was relocked.

Reported by: markj

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kib created this revision.Jan 18 2023, 9:12 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 18 2023, 9:12 PM

kib requested review of this revision.Jan 18 2023, 9:12 PM

Thanks, this fixes the panic I saw.

sys/vm/vm_object.c
1238	Why isn't it necessary to relock the vnode here like we do in md? And if we can simply call VOP_FSYNC() in a loop like this, why not handle the retry entirely in the VOP?

kib added inline comments.Jan 18 2023, 9:55 PM

sys/vm/vm_object.c
1238	Generally it is useful to unlock the vnode since it allows SU thread and bufdaemon to clean more dependencies that perhaps caused the relock during ffs_fsyncvnode(). I added the relock there.

Relock for vm_object_sync()

kib marked an inline comment as done.Jan 18 2023, 9:57 PM

markj accepted this revision.Jan 18 2023, 10:15 PM

markj added inline comments.

sys/vm/vm_object.c
1244

This revision is now accepted and ready to land.Jan 18 2023, 10:15 PM

Avoid duplicating VOP_FSYNC() call.
Move comment to the more logical place. Make it stylish.

This revision now requires review to proceed.Jan 18 2023, 10:31 PM

markj accepted this revision.Jan 19 2023, 3:49 PM

markj added inline comments.

sys/vm/vm_object.c
1249

This revision is now accepted and ready to land.Jan 19 2023, 3:49 PM

Closed by commit rG6189672e6008: Handle ERELOOKUP from VOP_FSYNC() in several other places (authored by kib). · Explain WhyJan 20 2023, 1:56 AM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG6189672e6008: Handle ERELOOKUP from VOP_FSYNC() in several other places.

Revision Contents
Changeset List

Path

Size

sys/

dev/

md/

12 lines

vm/

19 lines

Diff 115284

sys/dev/md/md.c

Loading...

sys/vm/vm_object.c

Loading...