Page MenuHomeFreeBSD

h_resolv: Fix a buffer overflow in load().
ClosedPublic

Authored by jhb on Dec 27 2022, 10:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 6, 5:07 AM
Unknown Object (File)
Thu, Nov 6, 5:02 AM
Unknown Object (File)
Thu, Nov 6, 1:33 AM
Unknown Object (File)
Wed, Nov 5, 11:34 AM
Unknown Object (File)
Wed, Nov 5, 10:39 AM
Unknown Object (File)
Sat, Nov 1, 5:40 AM
Unknown Object (File)
Wed, Oct 22, 3:48 AM
Unknown Object (File)
Wed, Oct 15, 10:42 PM
Subscribers

Details

Summary

fgetln() returns a pointer to an array of characters that is 'len'
characters long, not 'len + 1'. While here, overwriting the contents
of the buffer returned by fgetln isn't really safe, so switch to using
getline() instead.

Note that these fixes are a subset of those applied to a
near-identical copy of this function in libc's resolv_test.c in commit
2afeaad315ac19450389b8f2befdbe7c91c37818.

Reported by: CHERI (buffer overflow)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable