GEOM: Remove redundant NULL pointer check before g_free()
ClosedPublic
Actions

Authored by zlei on Dec 22 2022, 9:24 AM.

Details

Reviewers

imp
pjd
kp
melifaro

Commits

rG71a44d641fe0: GEOM: Remove redundant NULL pointer check before g_free()
rGbd5d9037c5dd: GEOM: Remove redundant NULL pointer check before g_free()

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

zlei requested review of this revision.Dec 22 2022, 9:24 AM

zlei created this revision.

melifaro accepted this revision.Dec 22 2022, 4:11 PM

This revision is now accepted and ready to land.Dec 22 2022, 4:11 PM

pjd accepted this revision.Dec 23 2022, 12:10 AM

Confirmed that the comparison is always redundant: g_free just calls free, but even the extra diagnostics that seem to touch g_free doesn't really touch it (it looks for it on lists, which it will never find a null pointer on...) and even if it does find a null pointer somehow, we don't dereference it (though I think it's impossible to find a null pointer).

Approved by: kp (mentor)

Closed by commit rGbd5d9037c5dd: GEOM: Remove redundant NULL pointer check before g_free() (authored by zlei). · Explain WhyDec 28 2022, 3:40 PM

This revision was automatically updated to reflect the committed changes.

zlei added a commit: rGbd5d9037c5dd: GEOM: Remove redundant NULL pointer check before g_free().

zlei added a commit: rG71a44d641fe0: GEOM: Remove redundant NULL pointer check before g_free().Jan 11 2023, 10:41 AM