Page MenuHomeFreeBSD

Commit message template: PR field now accepts bugs.freebsd.org URL.
AcceptedPublic

Authored by lwhsu on Dec 23 2022, 6:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 20, 9:47 PM
Unknown Object (File)
Jan 12 2024, 10:47 AM
Unknown Object (File)
Dec 20 2023, 8:30 AM
Unknown Object (File)
Dec 12 2023, 8:08 AM
Unknown Object (File)
Dec 9 2023, 7:16 AM
Unknown Object (File)
Dec 9 2023, 1:16 AM
Unknown Object (File)
Dec 8 2023, 8:07 PM
Unknown Object (File)
Nov 29 2023, 7:23 PM

Details

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 48874
Build 45763: arc lint + arc unit

Event Timeline

lwhsu requested review of this revision.Dec 23 2022, 6:18 PM
zlei added a subscriber: zlei.

Looks good to me.

This revision is now accepted and ready to land.Dec 25 2022, 10:14 AM
grahamperrin added inline comments.
tools/tools/git/hooks/prepare-commit-msg
45

Is it clear enough that there should be no more than one URL per line?

A committer might type something like this (not exceeding 72 characters):

PR: https://bugs.freebsd.org/###### https://bugs.freebsd.org/######

tools/tools/git/hooks/prepare-commit-msg
45

… sorry, I could not find the related report at the time of my previous comment.

I visualise any string of two or more white space-separated URLs, on a single line, resulting in a single, invalid link in cgit.

From FreeBSD bug 266473 – cgit.freebsd.org breaks some links – seems to not recognise some types of URI delimiter (RFC 3986):

{F53896353}