ktls_tests: Log more details when a test fails.
ClosedPublic
Actions

Authored by jhb on Dec 13 2022, 11:24 PM.

Details

Reviewers

markj
gallatin
olivier

Commits

rG883d1742d3d7: ktls_tests: Log more details when a test fails.

Summary

Make use of ATF_REQUIRE_INTEQ to log the values of integers for unexpected mismatches.

Use ATF_REQUIRE_MSG in a few more places to log values when a requirement fails.

Consistently use ATF_REQUIRE_ERRNO when checking for an expected errno value.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 48707
Build 45593: arc lint + arc unit

Event Timeline

jhb created this revision.Dec 13 2022, 11:24 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 13 2022, 11:24 PM

jhb requested review of this revision.Dec 13 2022, 11:24 PM

Harbormaster completed remote builds in B48707: Diff 114114.Dec 13 2022, 11:24 PM

jhb added a child revision: D37692: ktls: Close a race with setting so_error when dropping a connection..Dec 13 2022, 11:24 PM

olivier mentioned this in D37693: ktls_tests: Ignore spurious errors from shutdown(2)..Dec 14 2022, 1:28 PM

markj accepted this revision.Dec 14 2022, 3:20 PM

markj added inline comments.

tests/sys/kern/ktls_test.c
2152	You can combine the two assertions: ATF_REQUIRE_ERRNO(EINVAL, setsockopt(...) == -1);
2649	Ditto.
2689	Ditto.

This revision is now accepted and ready to land.Dec 14 2022, 3:20 PM

jhb marked 3 inline comments as done.Dec 15 2022, 7:31 PM

Closed by commit rG883d1742d3d7: ktls_tests: Log more details when a test fails. (authored by jhb). · Explain WhyDec 15 2022, 8:07 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG883d1742d3d7: ktls_tests: Log more details when a test fails..

Revision Contents
Changeset List

Path

Size

tests/

sys/

kern/

ktls_test.c

148 lines

Diff 114114

View Options

tests/sys/kern/ktls_test.c

ktls_tests: Log more details when a test fails.ClosedPublicActions