drm-kmod: package description: correct and update
Needs ReviewPublic
Actions

Authored by grahamperrin on Dec 11 2022, 9:38 AM.

Details

Reviewers

Group Reviewers

desktop
docs
Doc Committers

Summary

drm-kmod: package description: correct and update by grahamperrin · Pull Request #140 · freebsd/freebsd-ports

Correct a typo (given, not give).

Whilst here: aim to make the description more understandable to readers who may be new to, or relatively unfamiliar, with things such as DRM. In particular:

make clearer that modules are in a separate port (not this metaport).

Contexts include:

Origin of diff 114131 a.k.a. Diff 3:

https://patch-diff.githubusercontent.com/raw/freebsd/freebsd-ports/pull/140.diff.

Test Plan

Preview in GitHub:

https://github.com/grahamperrin/freebsd-ports/blob/patch-1/graphics/drm-kmod/pkg-descr.

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

grahamperrin requested review of this revision.Dec 11 2022, 9:38 AM

grahamperrin created this revision.

grahamperrin added a comment.Dec 11 2022, 9:53 AM

This comment was removed by grahamperrin.

grahamperrin edited the summary of this revision. (Show Details)Dec 11 2022, 10:13 AM

There are trailing white spaces in almost end of every line.

This revision now requires changes to proceed.Dec 13 2022, 12:33 AM

Trailing white spaces removed.

(Inclusion will be a very hard habit to break. Sorry.)

tcberner added a subscriber: tcberner.Dec 13 2022, 5:02 AM

tcberner added inline comments.

graphics/drm-kmod/pkg-descr
2–4	^ I think the stuff in parentheses might make it more wordy than required.

manu added a subscriber: manu.Dec 13 2022, 7:19 AM

manu added inline comments.

graphics/drm-kmod/pkg-descr
3	I don't understand this part, "from the former base DRM component ..." ?
6	That's implied with how dev works everywhere and not needed here.

grahamperrin marked 3 inline comments as done.Dec 14 2022, 6:14 AM

grahamperrin added inline comments.

graphics/drm-kmod/pkg-descr
2–4	Removed, with an additional thought.
3	Re: https://github.com/freebsd/freebsd-ports/pull/140/commits/3d42c2d313ad7614e24ea4d8f0ac8e73a3de4790#r1045205350 I found the original paragraph (as a whole) difficult to understand. How does https://github.com/grahamperrin/freebsd-ports/blob/patch-1/graphics/drm-kmod/pkg-descr look now?
6	Removed.