Allow any user to read the NFS stats, for example with nfsstat(1).
ClosedPublic
Actions

Authored by asomers on Dec 1 2022, 9:10 PM.

Details

Reviewers

rmacklem
ken

Commits

rG1961075a6972: Allow any user to read the NFS stats, for example with nfsstat(1).
rGd2ce00e9a617: Allow any user to read the NFS stats, for example with nfsstat(1).

Summary

This was originally allowed by 3cea29603d3 (2011). But it got broken by
693957f8861 (2016) and apparently nobody noticed.

MFC after: 1 week
Sponsored by: Axcient

Test Plan

manually tested

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 48597
Build 45483: arc lint + arc unit

Event Timeline

asomers created this revision.Dec 1 2022, 9:10 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 1 2022, 9:10 PM

asomers requested review of this revision.Dec 1 2022, 9:10 PM

Harbormaster completed remote builds in B48597: Diff 113764.Dec 1 2022, 9:10 PM

This looks good to me.

I guess we only ever tested as root. Thanks for catching this, this will be helpful.

This revision is now accepted and ready to land.Dec 1 2022, 9:35 PM

Looks good to me, rick

Closed by commit rGd2ce00e9a617: Allow any user to read the NFS stats, for example with nfsstat(1). (authored by asomers). · Explain WhyDec 2 2022, 5:21 AM

This revision was automatically updated to reflect the committed changes.

asomers added a commit: rGd2ce00e9a617: Allow any user to read the NFS stats, for example with nfsstat(1)..

Ok, I committed it. Next I'll fix sysutils/nfs_exporter to run as non-root too.

asomers added a commit: rG1961075a6972: Allow any user to read the NFS stats, for example with nfsstat(1)..Jan 27 2023, 5:12 PM

Revision Contents
Changeset List

Path

Size

sys/

nfs/

nfs_nfssvc.c

2 lines

Diff 113764

View Options

Allow any user to read the NFS stats, for example with nfsstat(1).ClosedPublicActions