Page MenuHomeFreeBSD

net80211: try to fix IEEE80211_DEBUG_REFCNT builds
ClosedPublic

Authored by bz on Nov 29 2022, 12:56 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 21, 10:16 AM
Unknown Object (File)
Sat, Apr 6, 1:22 AM
Unknown Object (File)
Jan 6 2024, 11:12 PM
Unknown Object (File)
Jan 6 2024, 11:07 PM
Unknown Object (File)
Dec 23 2023, 3:02 AM
Unknown Object (File)
Nov 18 2023, 5:02 AM
Unknown Object (File)
Sep 30 2023, 7:14 PM
Unknown Object (File)
Sep 21 2023, 10:21 PM

Details

Summary

Remove the KPI/KBI changes from ieee80211_node.h and always use the
macros to pass in func and LINE to the functions.
The actual implementations are prefixed by "_" rather than suffixed
by "_debug" as they no longer are "debug"-specific.

Some of the select functions were not actually using the passed in
func, line options; however they are calling other functions which
use them. Directly call the internal implementation in those cases
passing the arguments on.

Use a file-local debrefcnt_used define to mark the arguments unused
in cases when we compile without IEEE80211_DEBUG_REFCNT and hope the
toolchain is intelligent enough to not pass them at all in those cases.

Also _ieee80211_free_node() now has a conflict so make the previous
_ieee80211_free_node() the new __ieee80211_free_node().

Add IEEE80211_DEBUG_REFCNT to the NOTES file on amd64 to keep exercising
the option.

Discussed on: freebsd-wireless
Sponsored by: The FreeBSD Foundation
X-MFC: never

Test Plan

This is a first cut making the changes and make things compile.
There is a further question of usefulness on the current incarnation
and how much to extend and cleanup but that is left for later.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 48529
Build 45415: arc lint + arc unit