Details

Reviewers

kib
emaste
andrew
imp

Commits

rS292407: Import RISC-V machine headers. This is a minimal set required to compile

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

br updated this revision to Diff 11241.Dec 14 2015, 6:27 PM

br retitled this revision from to RISC-V includes.

br updated this object.

br edited the test plan for this revision. (Show Details)

br added reviewers: andrew, emaste.

andrew added inline comments.Dec 14 2015, 7:31 PM

sys/riscv/include/_types.h
98–99	These are wrong for an int. arm & arm64 have unsigned `wchar_t` where i tseems to be signed on riscv.
sys/riscv/include/atomic.h
67	Should these also have "memory" in the clobber list to stop them from being reordered?
sys/riscv/include/exec.h
41	I don't think this is needed, it was for a.out.
sys/riscv/include/float.h
80	Needed?
sys/riscv/include/frame.h
50	Why 32? I thought x0 only ever contained zero.
sys/riscv/include/intr.h
39	Is this needed?
sys/riscv/include/kdb.h
33–34	We don't have these on arm64, they might not be needed.
sys/riscv/include/ofw_machdep.h
32–35	These have been replaces with `<vm/vm.h>` in the arm64 version.
sys/riscv/include/param.h
86–92	Do oyu need these? They look like arm64 things to support multiple page sizes.
108–110	Is this needed? I'm not sure if it is on arm64, it was copied from sparc64 but the only other place that uses it is i386.
sys/riscv/include/pcb.h
51	Do you need all 32 registers?
sys/riscv/include/pcpu.h
40	I think this should be 129
sys/riscv/include/pmc_mdep.h
35	Do we need this file if we don't support PMC?
sys/riscv/include/reg.h
42	32?
sys/riscv/include/ucontext.h
42	32?
48	I would suggest you pad this to the expected size of these registers
52	Then add it here with a flag field & padding

andrew added a reviewer: imp.Dec 14 2015, 7:31 PM

br updated this revision to Diff 11328.Dec 15 2015, 8:25 PM

br added inline comments.Dec 15 2015, 8:32 PM

sys/riscv/include/pcpu.h
41	thanks. how it is calculated ?
sys/riscv/include/pmc_mdep.h
36	Yes it is used by kern_pmc.c: sys/conf/files:kern/kern_pmc.c standard

few more defines added

andrew added a reviewer: kib.Dec 17 2015, 10:35 AM

andrew added inline comments.

sys/riscv/include/_types.h
97	`__WCHAR_MIN` should be `__INT_MIN`
sys/riscv/include/pcpu.h
41	There is a compile time assert: CTASSERT((PAGE_SIZE / sizeof(struct pcpu)) * sizeof(struct pcpu) == PAGE_SIZE); `PCPU_MD_FIELDS` is placed at the end of `struct pcpu`

WCHAR_MIN fixed

kib added inline comments.Dec 17 2015, 3:54 PM

sys/riscv/include/signal.h
41	This contradicts the definition of the SIG_ATOMIC_MIN and SIG_ATOMIC_MAX. Amd64 has a bug there, which is hard to fix due to the ABI.

These look fine, modulo my standing comment that we're duplicating *WAY* too much in the
headers. :(

This revision is now accepted and ready to land.Dec 17 2015, 4:00 PM

andrew accepted this revision.Dec 17 2015, 4:33 PM

andrew edited edge metadata.

andrew added inline comments.

sys/riscv/include/minidump.h
38–46	I expect this will change, but only becomes an ABI when we use it.
sys/riscv/include/signal.h
41	I note arm64 has the same issue.
sys/riscv/include/ucontext.h
54	Should these be `__int128_t`?
55–56	I assume these are correct.

Closed by commit rS292407: Import RISC-V machine headers. This is a minimal set required to compile (authored by br). · Explain WhyDec 17 2015, 6:44 PM

This revision was automatically updated to reflect the committed changes.

RISC-V includesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 11358

sys/riscv/include/_align.h

sys/riscv/include/_bus.h

sys/riscv/include/_inttypes.h

sys/riscv/include/_limits.h

sys/riscv/include/_stdint.h

sys/riscv/include/_types.h

sys/riscv/include/asm.h

sys/riscv/include/atomic.h

sys/riscv/include/bus.h

sys/riscv/include/bus_dma.h

sys/riscv/include/clock.h

sys/riscv/include/counter.h

sys/riscv/include/cpu.h

sys/riscv/include/cpufunc.h

sys/riscv/include/db_machdep.h

sys/riscv/include/dump.h

sys/riscv/include/elf.h

sys/riscv/include/endian.h

sys/riscv/include/exec.h

sys/riscv/include/float.h

sys/riscv/include/floatingpoint.h

sys/riscv/include/frame.h

sys/riscv/include/ieeefp.h

sys/riscv/include/in_cksum.h

sys/riscv/include/intr.h

sys/riscv/include/kdb.h

sys/riscv/include/machdep.h

sys/riscv/include/md_var.h

sys/riscv/include/memdev.h

sys/riscv/include/minidump.h

sys/riscv/include/ofw_machdep.h

sys/riscv/include/param.h

sys/riscv/include/pcb.h

sys/riscv/include/pcpu.h

sys/riscv/include/pmap.h

sys/riscv/include/pmc_mdep.h

sys/riscv/include/proc.h

sys/riscv/include/profile.h

sys/riscv/include/psl.h

sys/riscv/include/pte.h

sys/riscv/include/ptrace.h

sys/riscv/include/reg.h

sys/riscv/include/reloc.h

sys/riscv/include/resource.h

sys/riscv/include/riscvreg.h

sys/riscv/include/runq.h

sys/riscv/include/setjmp.h

sys/riscv/include/sf_buf.h

sys/riscv/include/signal.h

sys/riscv/include/smp.h

sys/riscv/include/stdarg.h

sys/riscv/include/sysarch.h

sys/riscv/include/trap.h

sys/riscv/include/ucontext.h

sys/riscv/include/vdso.h

sys/riscv/include/vm.h

sys/riscv/include/vmparam.h

RISC-V includes
ClosedPublic
Actions

Revision Contents
Changeset List