ClosedPublic
Actions

Authored by dumbbell on Nov 11 2022, 6:29 PM.

Details

Reviewers

manu
bz

Commits

rG577e5458c520: linuxkpi: Define `pci_reset_function()` in <linux/pci.h>
rG86a1c5d12945: linuxkpi: Define `pci_reset_function()` in <linux/pci.h>

Summary

Currently, it always returns an error on FreeBSD.

This change is a requirement to update our DRM drivers to Linux 5.12.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dumbbell created this revision.Nov 11 2022, 6:29 PM

Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptNov 11 2022, 6:29 PM

dumbbell requested review of this revision.Nov 11 2022, 6:29 PM

bz accepted this revision.Nov 11 2022, 7:05 PM

bz added a subscriber: bz.

bz added inline comments.

sys/compat/linuxkpi/common/include/linux/pci.h
947	Would there be any harm in implementing it? I am just asking what the effects would be on drm-kmod -- or what they are now if this doesn't work?

This revision is now accepted and ready to land.Nov 11 2022, 7:05 PM

manu accepted this revision.Nov 11 2022, 7:47 PM

I admit I didn't digged deeper into this yet. My focus was on finishing the backport of Linux 5.12 drivers. But I will take a look to understand what the impact is in the drivers.

Closed by commit rG86a1c5d12945: linuxkpi: Define `pci_reset_function()` in <linux/pci.h> (authored by dumbbell). · Explain WhyNov 11 2022, 8:06 PM

This revision was automatically updated to reflect the committed changes.

dumbbell added a commit: rG86a1c5d12945: linuxkpi: Define `pci_reset_function()` in <linux/pci.h>.

manu added a commit: rG577e5458c520: linuxkpi: Define `pci_reset_function()` in <linux/pci.h>.Jan 24 2023, 8:56 AM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

pci.h

7 lines

Diff 113014

View Options

sys/compat/linuxkpi/common/include/linux/pci.h

linuxkpi: Define `pci_reset_function()` in <linux/pci.h>ClosedPublicActions