rubygem-google-protobuf: Use hidden symbols
ClosedPublic
Actions

Authored by dan.mcgregor_usask.ca on Oct 26 2022, 9:17 PM.

Details

Reviewers

mfechner
sunpoet

Commits

R11:b5673e0619b5: devel/rubygem-google-protobuf*: fix segfaults caused by public symbols

Summary

The Linux and Darwin builds hide the symbols in the native shared
object. This prevents some symbol collisions if this gem is loaded
alongside certain others (that should probably also hide their symbols).

This fixes numerous issues with gitaly and protobuf 3.20 and newer.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 48013
Build 44900: arc lint + arc unit

Event Timeline

dan.mcgregor_usask.ca created this revision.Oct 26 2022, 9:17 PM

Herald added subscribers: Contributor Reviewers (ports), mat. · View Herald TranscriptOct 26 2022, 9:17 PM

dan.mcgregor_usask.ca requested review of this revision.Oct 26 2022, 9:17 PM

Harbormaster completed remote builds in B48013: Diff 112233.Oct 26 2022, 9:17 PM

dan.mcgregor_usask.ca added a reviewer: mfechner.Oct 26 2022, 9:17 PM

Also created this pull request.

arrowd added a reviewer: sunpoet.Oct 28 2022, 4:30 AM

Thanks a lot, I tested it and can confirm that fixes the problem. @sunpoet could you please commit this, as you are the maintainer of these ports.
Thanks a lot.

This revision is now accepted and ready to land.Oct 28 2022, 2:32 PM

Thanks for taking a look. I don't think the change to the 3.19 port is strictly necessary, but as I said in a private email to @mfechner, I do believe that hiding symbols is good practice for ruby gems.

The change to 3.2x *is* necessary, though.

Closed by commit R11:b5673e0619b5: devel/rubygem-google-protobuf*: fix segfaults caused by public symbols (authored by dan.mcgregor_usask.ca, committed by mfechner). · Explain WhyNov 19 2022, 5:13 AM

This revision was automatically updated to reflect the committed changes.

mfechner added a commit: R11:b5673e0619b5: devel/rubygem-google-protobuf*: fix segfaults caused by public symbols.

Thanks!