ddb: Don't flag breakpoint/watchpoint commands as MEMSAFE
ClosedPublic
Actions

Authored by markj on Oct 24 2022, 4:28 PM.

Tags

None

Referenced Files

	F168876126: D37105.id112147.diff
	Sun, Aug 30, 1:52 PM

	Unknown Object (File)
	Tue, Aug 18, 5:33 PM

	Unknown Object (File)
	Mon, Aug 17, 4:13 PM

	Unknown Object (File)
	Mon, Aug 17, 4:13 PM

	Unknown Object (File)
	Sun, Aug 16, 10:33 AM

	Unknown Object (File)
	Fri, Aug 14, 4:05 AM

	Unknown Object (File)
	Wed, Aug 12, 8:44 PM

	Unknown Object (File)
	Wed, Aug 12, 8:37 PM

View All Files

Subscribers

imp

Details

Reviewers

stevek
mhorne

Commits

rGc036339ddf0c: ddb: Don't flag breakpoint/watchpoint commands as MEMSAFE

Summary

They could potentially be abused to overwrite kernel memory.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 47970
Build 44857: arc lint + arc unit

Event Timeline

markj created this revision.Oct 24 2022, 4:28 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 24 2022, 4:28 PM

markj requested review of this revision.Oct 24 2022, 4:28 PM

Harbormaster completed remote builds in B47970: Diff 112147.Oct 24 2022, 4:28 PM

markj added a child revision: D37106: kdb: Conditionally permit breaking to DDB with a raised securelevel.Oct 24 2022, 4:29 PM

mhorne accepted this revision.Oct 24 2022, 6:49 PM

This revision is now accepted and ready to land.Oct 24 2022, 6:49 PM

Closed by commit rGc036339ddf0c: ddb: Don't flag breakpoint/watchpoint commands as MEMSAFE (authored by markj). · Explain WhyNov 2 2022, 5:47 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGc036339ddf0c: ddb: Don't flag breakpoint/watchpoint commands as MEMSAFE.

Revision Contents
Changeset List

Path

Size

sys/

ddb/

db_command.c

16 lines

Diff 112147

View Options

ddb: Don't flag breakpoint/watchpoint commands as MEMSAFEClosedPublicActions