ddb: Don't flag breakpoint/watchpoint commands as MEMSAFE
ClosedPublic
Actions

Authored by markj on Oct 24 2022, 4:28 PM.

Tags

None

Referenced Files

	F154213237: D37105.id.diff
	Mon, Apr 27, 4:17 AM

	Unknown Object (File)
	Tue, Apr 21, 11:05 AM

	Unknown Object (File)
	Tue, Apr 21, 7:26 AM

	Unknown Object (File)
	Mon, Apr 20, 9:34 AM

	Unknown Object (File)
	Mon, Apr 20, 12:21 AM

	Unknown Object (File)
	Sun, Apr 19, 9:57 PM

	Unknown Object (File)
	Sun, Apr 19, 11:49 AM

	Unknown Object (File)
	Sat, Apr 18, 8:21 AM

View All Files

Subscribers

imp

Details

Reviewers

stevek
mhorne

Commits

rGc036339ddf0c: ddb: Don't flag breakpoint/watchpoint commands as MEMSAFE

Summary

They could potentially be abused to overwrite kernel memory.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Oct 24 2022, 4:28 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 24 2022, 4:28 PM

markj requested review of this revision.Oct 24 2022, 4:28 PM

Harbormaster completed remote builds in B47970: Diff 112147.Oct 24 2022, 4:28 PM

markj added a child revision: D37106: kdb: Conditionally permit breaking to DDB with a raised securelevel.Oct 24 2022, 4:29 PM

mhorne accepted this revision.Oct 24 2022, 6:49 PM

This revision is now accepted and ready to land.Oct 24 2022, 6:49 PM

Closed by commit rGc036339ddf0c: ddb: Don't flag breakpoint/watchpoint commands as MEMSAFE (authored by markj). · Explain WhyNov 2 2022, 5:47 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGc036339ddf0c: ddb: Don't flag breakpoint/watchpoint commands as MEMSAFE.

Revision Contents
Changeset List

Path

Size

sys/

ddb/

db_command.c

16 lines

Diff 112524

View Options

ddb: Don't flag breakpoint/watchpoint commands as MEMSAFEClosedPublicActions