Page MenuHomeFreeBSD
Differential D37088

LinuxKPI: add kstrtou32_from_user() and mac_pton()
ClosedPublic
Actions

Authored by bz on Oct 22 2022, 6:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 4, 1:35 PM
Unknown Object (File)
Wed, Apr 1, 3:30 AM
Unknown Object (File)
Thu, Mar 26, 7:11 AM
Unknown Object (File)
Thu, Mar 26, 12:29 AM
Unknown Object (File)
Wed, Mar 25, 6:06 PM
Unknown Object (File)
Tue, Mar 24, 11:49 PM
Unknown Object (File)
Tue, Mar 24, 10:17 AM
Unknown Object (File)
Tue, Mar 24, 10:17 AM
View All Files
Subscribers
emaste
imp

Details

Reviewers
None
Group Reviewers
linuxkpi
x11
Commits
rGb1479a5409cf: LinuxKPI: add kstrtou32_from_user() and mac_pton()
rGf82cf28b317b: LinuxKPI: add kstrtou32_from_user() and mac_pton()
Summary

Add kstrtou32_from_user() based on other examples in the file.

Also add a rudimentarily hacked up version of mac_pton() which is
leanient accepting non-well-formed input but so far only with ':'
separators. It does not seem to obviously belong to any networking
header file so add it here.

Both are needed for debugfs supprot for iwlwifi.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Test Plan

Someone should make sure the mac_pton does indeed work.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 47956
Build 44843: arc lint + arc unit

Event Timeline

bz created this revision.Oct 22 2022, 6:08 PM
Herald added subscribers: emaste, imp. · View Herald TranscriptOct 22 2022, 6:08 PM
bz requested review of this revision.Oct 22 2022, 6:08 PM
Harbormaster completed remote builds in B47956: Diff 112100.Oct 22 2022, 6:08 PM
bz added a comment.Nov 7 2022, 1:14 PM

Anyone? Or would it help if I split this up into two part?

emaste added a comment.Nov 7 2022, 2:51 PM

Looks OK, even if there is duplication between kstrtou32_from_user and kstrtouint_from_user, and kstrtou32 and kstrtouint. I guess we can hope the compiler optimizes that away.

sys/compat/linuxkpi/common/include/linux/kernel.h
751

What about strings with too many digits, e.g. 123:456:....

bz added a comment.Nov 8 2022, 6:02 PM
In D37088#847359, @emaste wrote:

Looks OK, even if there is duplication between kstrtou32_from_user and kstrtouint_from_user, and kstrtou32 and kstrtouint. I guess we can hope the compiler optimizes that away.

I am wondering why kstrtouint_from_user() has an int * argument and not an uint_t *? Otherwise we could probably #define one to the other (and the same for kstrtoxxx(). Should I just do that and fix the type? In that case probably splitting this up makes sense?

emaste added a comment.Nov 8 2022, 6:07 PM

I am wondering why kstrtouint_from_user() has an int * argument and not an uint_t *

Oh, I didn't look close enough to spot that :)
Looks like it was a bug in 8e587a5f13ce676d7763ffa920148fe31bc3bfae

bz updated this revision to Diff 112780.Nov 8 2022, 6:12 PM
bz edited the test plan for this revision. (Show Details)

#redefine two u32 to the uint versions; fix an argument from int to uint
in one version.

Check for invalid long input in mac_pton().

Harbormaster completed remote builds in B48234: Diff 112780.Nov 8 2022, 6:12 PM
bz added a comment.Nov 15 2022, 11:04 PM

@emaste (or anyone else) -- does this look better now?

bz added a reviewer: x11.Dec 18 2022, 10:11 PM

Adding x11 as that is where the original kstrtouint_from_user() came from (now unsigned as it should have been).

Unless there's any further comments this will go in before the Christmas holidays.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 13 2023, 12:37 AM
Closed by commit rGf82cf28b317b: LinuxKPI: add kstrtou32_from_user() and mac_pton() (authored by bz). · Explain Why
This revision was automatically updated to reflect the committed changes.
bz marked an inline comment as done.
bz added a commit: rGf82cf28b317b: LinuxKPI: add kstrtou32_from_user() and mac_pton().
bz added a commit: rGb1479a5409cf: LinuxKPI: add kstrtou32_from_user() and mac_pton().Jan 18 2023, 4:27 PM

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
54 lines

Diff 112100

View Options

sys/compat/linuxkpi/common/include/linux/kernel.h

Loading...