Page MenuHomeFreeBSD
Differential D37031

ofw: add BUS_GET_DEVICE_PATH interface to openfirm/fdt, somewhat incomplete.
ClosedPublic
Actions

Authored by takawata on Oct 18 2022, 6:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 2, 5:36 AM
Unknown Object (File)
Thu, Oct 30, 1:35 AM
Unknown Object (File)
Thu, Oct 16, 3:19 AM
Unknown Object (File)
Mon, Oct 13, 3:37 PM
Unknown Object (File)
Sun, Oct 12, 4:05 PM
Unknown Object (File)
Sun, Oct 12, 12:11 PM
Unknown Object (File)
Thu, Oct 9, 8:40 PM
Unknown Object (File)
Thu, Oct 9, 8:40 PM
View All 93 Files
Subscribers
andrew
emaste
imp

Details

Reviewers
manu
andrew
Commits
rG7b5d62bb73e3: ofw: add BUS_GET_DEVICE_PATH interface to openfirm/fdt, somewhat incomplete.
Summary

This add BUS_GET_DEVICE_PATH allow device tree of openfirm/fdt.

Test Plan

In qemu-system-arm64 with "virt" machine with device-tree firmware,
% devctl getpath OF cpu0

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 47868
Build 44755: arc lint + arc unit

Event Timeline

takawata created this revision.Oct 18 2022, 6:26 AM
Herald added a reviewer: manu. · View Herald TranscriptOct 18 2022, 6:26 AM
Herald added subscribers: emaste, andrew, imp. · View Herald Transcript
takawata requested review of this revision.Oct 18 2022, 6:26 AM
Harbormaster completed remote builds in B47868: Diff 111910.Oct 18 2022, 6:26 AM
andrew accepted this revision.Oct 18 2022, 7:14 AM

It might be better to name the selector "OFW" to be consistant with the directory name, ofwdump, etc.

sys/arm/arm/gic.c
1215

This should be in gic_fdt.c

sys/dev/ofw/ofw_bus_subr.c
113

Extra space before strcmp and "OF" should be BUS_LOCATOR_OF and defined in sys/bus.h

120

return (bus_generic_get_device_path(...));

This revision is now accepted and ready to land.Oct 18 2022, 7:14 AM
Closed by commit rG7b5d62bb73e3: ofw: add BUS_GET_DEVICE_PATH interface to openfirm/fdt, somewhat incomplete. (authored by takawata). · Explain WhyOct 18 2022, 8:01 AM
This revision was automatically updated to reflect the committed changes.
takawata added a commit: rG7b5d62bb73e3: ofw: add BUS_GET_DEVICE_PATH interface to openfirm/fdt, somewhat incomplete..

Revision Contents
Changeset List

PathSize
sys/
arm/
arm/
1 line
arm64/
arm64/
1 line
dev/
fdt/
1 line
ofw/
1 line
16 lines
1 line

Diff 111910

View Options

sys/arm/arm/gic.c

Loading...
View Options

sys/arm64/arm64/gic_v3_fdt.c

Loading...
View Options

sys/dev/fdt/simplebus.c

Loading...
View Options

sys/dev/ofw/ofw_bus_subr.h

Loading...
View Options

sys/dev/ofw/ofw_bus_subr.c

Loading...
View Options

sys/dev/ofw/ofw_cpu.c

Loading...