Paths

Table of Contentst

Differential D36959

linuxkpi: Add `krealloc_array()`
ClosedPublic
Actions

Authored by dumbbell on Oct 12 2022, 7:17 PM.

Tags

None

Referenced Files

	F144966252: D36959.diff
	Sat, Feb 14, 2:02 PM

	F144927950: D36959.id112954.diff
	Sat, Feb 14, 5:11 AM

	F144927944: D36959.id112954.diff
	Sat, Feb 14, 5:11 AM

	Unknown Object (File)
	Sun, Feb 8, 3:38 PM

	Unknown Object (File)
	Sat, Feb 7, 5:23 PM

	Unknown Object (File)
	Sat, Jan 31, 6:01 AM

	Unknown Object (File)
	Wed, Jan 28, 5:02 AM

	Unknown Object (File)
	Fri, Jan 16, 10:08 PM

Subscribers

Details

Reviewers

Commits

rGe1534bafdab9: linuxkpi: Add `krealloc_array()`
rG1ad6b2b1daa8: linuxkpi: Add `krealloc_array()`

Summary

In FreeBSD, this is a wrapper on top of realloc().

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 47807
Build 44694: arc lint + arc unit

Event Timeline

dumbbell created this revision.Oct 12 2022, 7:17 PM

Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptOct 12 2022, 7:17 PM

dumbbell requested review of this revision.Oct 12 2022, 7:17 PM

Harbormaster completed remote builds in B47807: Diff 111729.Oct 12 2022, 7:17 PM

dumbbell mentioned this in D36869: This patch contains [[ https://github.com/dumbbell/freebsd-src/tree/linuxkpi-changes-for-drm-from-5.11 | a series of commits to linuxkpi ]] in order to support an update of the DRM drivers to match Linux 5.11:.Oct 12 2022, 7:32 PM

dumbbell added a subscriber: • hselasky.Oct 12 2022, 7:35 PM

dumbbell added inline comments.

sys/compat/linuxkpi/common/include/linux/slab.h
184	In the original review (D36869), @hselasky said: Are we missing any n * size overflow checks? In a reply to his comment, I replied with the following questions: What is the usual behavior to react to such overflow? Fail and return `NULL`? Panic? If you know of an example in the kernel, could you please share it?

emaste added inline comments.Oct 12 2022, 7:43 PM

sys/compat/linuxkpi/common/include/linux/slab.h
184	Linux returns NULL on overflow.

Thank you @hselasky and @emaste! I updated the patch to check overflow.

dumbbell marked an inline comment as done.Nov 5 2022, 2:02 PM

manu accepted this revision.Nov 5 2022, 5:19 PM

This revision is now accepted and ready to land.Nov 5 2022, 5:19 PM

Closed by commit rG1ad6b2b1daa8: linuxkpi: Add `krealloc_array()` (authored by dumbbell). · Explain WhyNov 11 2022, 5:59 PM

This revision was automatically updated to reflect the committed changes.

dumbbell added a commit: rG1ad6b2b1daa8: linuxkpi: Add `krealloc_array()`.

manu added a commit: rGe1534bafdab9: linuxkpi: Add `krealloc_array()`.Jan 24 2023, 8:56 AM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

6 lines

Diff 111729

sys/compat/linuxkpi/common/include/linux/slab.h

Loading...