Page MenuHomeFreeBSD
Differential D36827

nvmecontrol wdc: Don't pass a bogus pointer to free().
ClosedPublic
Actions

Authored by jhb on Sep 29 2022, 10:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 26, 8:05 AM
Unknown Object (File)
Tue, May 26, 8:01 AM
Unknown Object (File)
Mon, May 25, 11:29 PM
Unknown Object (File)
Mon, May 25, 11:24 PM
Unknown Object (File)
Thu, May 21, 5:04 PM
Unknown Object (File)
Mon, May 18, 2:19 AM
Unknown Object (File)
Mon, May 18, 2:13 AM
Unknown Object (File)
Sat, May 16, 3:08 PM
View All Files
Subscribers
dab

Details

Reviewers
imp
Commits
rG7597246911f8: nvmecontrol wdc: Don't pass a bogus pointer to free().
rG1187e46d1b38: nvmecontrol wdc: Don't pass a bogus pointer to free().
Summary

wdc_get_dui_log_size allocates a buffer and then advances the
returned pointer. Passing this advanced pointer to free() is UB,
so save the original pointer to pass to free() instead.

Reported by: GCC 12 -Wfree-nonheap-object

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 47641
Build 44528: arc lint + arc unit

Revision Contents
Changeset List

PathSize
sbin/
nvmecontrol/
modules/
wdc/
6 lines

Diff 111247

View Options

sbin/nvmecontrol/modules/wdc/wdc.c

Loading...