Page MenuHomeFreeBSD
Differential D36775

ipsec: retire sadb_msg_reserved in order to facilitate per-cpu refcounting
AbandonedPublic
Actions

Authored by mjg on Sep 28 2022, 5:14 PM.
Tags
None
Referenced Files
F83657460: D36775.id.diff
Mon, May 13, 5:06 AM
Unknown Object (File)
Sun, May 12, 11:32 AM
Unknown Object (File)
Sun, May 5, 9:48 PM
Unknown Object (File)
Mon, Apr 29, 12:54 AM
Unknown Object (File)
Sun, Apr 28, 11:54 AM
Unknown Object (File)
Fri, Apr 26, 12:20 PM
Unknown Object (File)
Feb 1 2024, 11:15 PM
Unknown Object (File)
Jan 19 2024, 4:15 PM
View All 15 Files
Subscribers
glebius
melifaro
zlei

Details

Reviewers
ae
Summary

The field is only used for debugging and the ref count would be too expensive to obtain.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

mjg created this revision.Sep 28 2022, 5:14 PM
Herald added subscribers: glebius, melifaro. · View Herald TranscriptSep 28 2022, 5:14 PM
mjg requested review of this revision.Sep 28 2022, 5:14 PM
zlei added a subscriber: zlei.Sep 29 2022, 1:36 AM

Looks good to me except for the ABI breakage.

sys/net/pfkeyv2.h
88

Will this removal break ABI ?

sbin/setkey and lib/libipsec have reference to this data type define struct sadb_msg {}

mjg abandoned this revision.Mar 12 2024, 10:33 PM

Revision Contents
Changeset List

PathSize
sys/
net/
1 line
netipsec/
17 lines
6 lines

Diff 111141

View Options

sys/net/pfkeyv2.h

Loading...
View Options

sys/netipsec/key.c

Loading...
View Options

sys/netipsec/key_debug.c

Loading...