crypto: move all zeroing into crypto_getreq
ClosedPublic
Actions

Authored by mjg on Sep 28 2022, 4:00 PM.

Details

Reviewers

jhb
markj

Commits

rG517547573a5b: crypto: move all zeroing into crypto_getreq

Summary

This avoids a memset with a size unknown at compilatin time, giving the compiler more room to optimize.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

mjg requested review of this revision.Sep 28 2022, 4:00 PM

mjg created this revision.

mjg added reviewers: jhb, markj.Sep 28 2022, 4:10 PM

markj added inline comments.Sep 28 2022, 4:25 PM

sys/opencrypto/crypto.c
1651	crypto_initreq() zeros the buffer, but _crypto_initreq() does not.

mjg updated this revision to Diff 111140.Sep 28 2022, 4:33 PM

mjg retitled this revision from crypto: eliminate a spurious memset from crypto_getreq to crypto: move all zeroing into crypto_getreq.

mjg edited the summary of this revision. (Show Details)

mjg added inline comments.

sys/opencrypto/crypto.c
1651	huh, you are right. i reworked the patch, key point being that M_ZERO loses information about the size, which does not need to happen.

markj accepted this revision.Sep 28 2022, 4:43 PM

This revision is now accepted and ready to land.Sep 28 2022, 4:43 PM

jhb accepted this revision.Sep 30 2022, 9:57 PM

Closed by commit rG517547573a5b: crypto: move all zeroing into crypto_getreq (authored by mjg). · Explain WhyNov 22 2022, 12:29 PM

This revision was automatically updated to reflect the committed changes.

mjg added a commit: rG517547573a5b: crypto: move all zeroing into crypto_getreq.

Herald added a subscriber: imp. · View Herald TranscriptNov 22 2022, 12:29 PM

Revision Contents
Changeset List

Path

Size

sys/

opencrypto/

crypto.c

12 lines

Diff 111140

View Options

crypto: move all zeroing into crypto_getreqClosedPublicActions