Paths

Table of Contentst

Differential D36633

cuse(3): Optimise small reads and writes.
ClosedPublic
Actions

Authored by • hselasky on Sep 20 2022, 2:00 PM.

Tags

None

Referenced Files

	F156748931: D36633.id111352.diff
	Sat, May 16, 2:29 AM

	F156748906: D36633.id110975.diff
	Sat, May 16, 2:29 AM

	F156748890: D36633.id111352.diff
	Sat, May 16, 2:29 AM

	F156748871: D36633.id110735.diff
	Sat, May 16, 2:28 AM

	F156748855: D36633.id110975.diff
	Sat, May 16, 2:28 AM

	F156748848: D36633.id110973.diff
	Sat, May 16, 2:28 AM

	F156748845: D36633.id110974.diff
	Sat, May 16, 2:28 AM

	F156748842: D36633.id111352.diff
	Sat, May 16, 2:28 AM

Subscribers

Details

Reviewers

meka_tilda.center
markj
imp

Commits

rGe3834c99ca43: cuse(3): Cosmetic change about testing boolean values.
rG8016b0fefdb6: cuse(3): Use bool type for boolean value instead of int type.
rG7c5ac67bc330: cuse(3): Optimise small reads and writes.
rG2ae08612424e: cuse(3): Cosmetic change about testing boolean values.
rG5e59b2734f77: cuse(3): Optimise small reads and writes.
rG8f0a3c9c3551: cuse(3): Use bool type for boolean value instead of int type.

Summary

When doing small reads and writes use an intermediate buffer to store the
data to save locking the remote process to access data.

MFC after: 1 week
Sponsored by: NVIDIA Networking

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

• hselasky created this revision.Sep 20 2022, 2:00 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 20 2022, 2:00 PM

@meka_tilda.center : Can you test this and see if there is any performance impact?

• hselasky retitled this revision from cuse: Optimise small reads and writes. to cuse(3): Optimise small reads and writes..Sep 20 2022, 2:02 PM

markj added inline comments.Sep 22 2022, 12:21 PM

sys/fs/cuse/cuse.c
1359	Can we lift this code into a subroutine? The indentation makes it hard to read.
1681	The comment should explain why it's necessary.
1690	When does this condition arise? The comparison `error > len` looks wrong, but I guess `error` holds the number of bytes copied upon success.

Address comments from @markj .

Move a comment.

Fix some whitespace that sneaked in.

Ping.

Generally I think this looks good.

sys/fs/cuse/cuse.c
837	Might make sense to do the int -> bool stuff in a separate commit... My quick scan doesn't see any issues.

This revision is now accepted and ready to land.Oct 3 2022, 3:12 PM

• hselasky marked an inline comment as done.Oct 3 2022, 3:35 PM

Closed by commit rG8f0a3c9c3551: cuse(3): Use bool type for boolean value instead of int type. (authored by • hselasky). · Explain WhyOct 3 2022, 3:37 PM

This revision was automatically updated to reflect the committed changes.

• hselasky added a commit: rG8f0a3c9c3551: cuse(3): Use bool type for boolean value instead of int type..

• hselasky added a commit: rG5e59b2734f77: cuse(3): Optimise small reads and writes..

• hselasky added a commit: rG2ae08612424e: cuse(3): Cosmetic change about testing boolean values..Oct 4 2022, 11:54 AM

• hselasky added a commit: rG7c5ac67bc330: cuse(3): Optimise small reads and writes..Oct 12 2022, 3:55 PM

• hselasky added a commit: rG8016b0fefdb6: cuse(3): Use bool type for boolean value instead of int type..

• hselasky added a commit: rGe3834c99ca43: cuse(3): Cosmetic change about testing boolean values..

Revision Contents
Changeset List

Path

Size

sys/

fs/

cuse/

140 lines

Diff 110974

sys/fs/cuse/cuse.c

Loading...