pf tests: require scapy for ether:short_pkt
ClosedPublic
Actions

Authored by mhorne on Sep 14 2022, 2:18 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Sep 6, 11:23 AM

	Unknown Object (File)
	Sun, Sep 6, 10:42 AM

	Unknown Object (File)
	Sun, Sep 6, 6:17 AM

	Unknown Object (File)
	Wed, Sep 2, 9:15 PM

	Unknown Object (File)
	Wed, Sep 2, 8:15 PM

	Unknown Object (File)
	Wed, Sep 2, 8:33 AM

	Unknown Object (File)
	Wed, Sep 2, 4:43 AM

	Unknown Object (File)
	Wed, Sep 2, 3:18 AM

Subscribers

Details

Reviewers

Commits

rG80dadb9c1acf: pf tests: require scapy for ether:short_pkt

Summary

The pft_ether.py script requires both python and scapy to be installed.
Check for this so we properly skip the test when it is unavailable.

Fixes: 07ffa50ba075d ("pf tests: test short packets")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 47376
Build 44263: arc lint + arc unit

Event Timeline

mhorne created this revision.Sep 14 2022, 2:18 PM

Herald added subscribers: glebius, melifaro, farrokhi, imp. · View Herald TranscriptSep 14 2022, 2:18 PM

mhorne requested review of this revision.Sep 14 2022, 2:18 PM

Harbormaster completed remote builds in B47376: Diff 110545.Sep 14 2022, 2:18 PM

kp accepted this revision.Sep 14 2022, 9:53 PM

This revision is now accepted and ready to land.Sep 14 2022, 9:53 PM

Closed by commit rG80dadb9c1acf: pf tests: require scapy for ether:short_pkt (authored by mhorne). · Explain WhySep 15 2022, 1:59 PM

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rG80dadb9c1acf: pf tests: require scapy for ether:short_pkt.

Revision Contents
Changeset List

Path

Size

tests/

sys/

netpfil/

pf/

ether.sh

1 line

Diff 110545

View Options

tests/sys/netpfil/pf/ether.sh

pf tests: require scapy for ether:short_pktClosedPublicActions